FFmpegPostProcessor: decode stderr first and then get the last line (closes #837)

2013-05-12 19:08:32 +02:00 · 2013-05-12 19:08:32 +02:00 · fb2f83360c
commit fb2f83360c
parent 3c5e7729e1
1 changed files with 2 additions and 1 deletions
--- a/youtube_dl/PostProcessor.py
+++ b/youtube_dl/PostProcessor.py
@ -85,8 +85,9 @@ class FFmpegPostProcessor(PostProcessor):
        p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
        stdout,stderr = p.communicate()
        if p.returncode != 0:
+            stderr = stderr.decode('utf-8', 'replace')
            msg = stderr.strip().split('\n')[-1]
-            raise FFmpegPostProcessorError(msg.decode('utf-8', 'replace'))
+            raise FFmpegPostProcessorError(msg)

    def _ffmpeg_filename_argument(self, fn):
        # ffmpeg broke --, see https://ffmpeg.org/trac/ffmpeg/ticket/2127 for details