yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-28 08:24:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix an AppVerifier STOP in OOP server code. In the destructor of

Browse Source 
the OOP server, we need to wait for any pending I/O to be done.



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@308 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
doshimun 2009-01-16 22:37:48 +00:00
parent 308947d1ce
commit 104e4e0114
2 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/client/windows/crash_generation/crash_generation_server.cc
View File

@ -129,6 +129,19 @@ CrashGenerationServer::~CrashGenerationServer() {
// Indicate to existing threads that server is shutting down. // Indicate to existing threads that server is shutting down.
shutting_down_ = true; shutting_down_ = true;
// Even if there are no current worker threads running, it is possible that
// an I/O request is pending on the pipe right now but not yet done. In fact,
// it's very likely this is the case unless we are in an ERROR state. If we
// don't wait for the pending I/O to be done, then when the I/O completes,
// it may write to invalid memory. AppVerifier will flag this problem too.
// So we disconnect from the pipe and then wait for the server to get into
// error state so that the pending I/O will fail and get cleared.
DisconnectNamedPipe(pipe_);
int num_tries = 100;
while (num_tries-- && server_state_ != IPC_SERVER_STATE_ERROR) {
Sleep(10);
}
// Unregister wait on the pipe. // Unregister wait on the pipe.
if (pipe_wait_handle_) { if (pipe_wait_handle_) {
// Wait for already executing callbacks to finish. // Wait for already executing callbacks to finish.
@ -629,6 +642,14 @@ bool CrashGenerationServer::RespondToClient(ClientInfo* client_info) {
// implements the state machine described in ReadMe.txt along with the // implements the state machine described in ReadMe.txt along with the
// helper methods HandleXXXState. // helper methods HandleXXXState.
void CrashGenerationServer::HandleConnectionRequest() { void CrashGenerationServer::HandleConnectionRequest() {
// If we are shutting doen then get into ERROR state, reset the event so more
// workers don't run and return immediately.
if (shutting_down_) {
server_state_ = IPC_SERVER_STATE_ERROR;
ResetEvent(overlapped_.hEvent);
return;
}
switch (server_state_) { switch (server_state_) {
case IPC_SERVER_STATE_ERROR: case IPC_SERVER_STATE_ERROR:
HandleErrorState(); HandleErrorState();

2
src/client/windows/crash_generation/crash_generation_server.h
View File

@ -241,7 +241,7 @@ class CrashGenerationServer {
// Note that since we restrict the pipe to one instance, we // Note that since we restrict the pipe to one instance, we
// only need to keep one state of the server. Otherwise, server // only need to keep one state of the server. Otherwise, server
// would have one state per client it is talking to. // would have one state per client it is talking to.
IPCServerState server_state_; volatile IPCServerState server_state_;
// Whether the server is shutting down. // Whether the server is shutting down.
volatile bool shutting_down_; volatile bool shutting_down_;