yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-28 07:14:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

breakpad: fix unittest failure when building with clang.

Browse Source 
In C/C++, the result of signed integer overflow is undefined.

The expression "base + size - 1" is parsed as "(base + size) - 1", and
"base + size" can overflow even if "base + (size - 1)" <= INT_MAX.

See http://g/c-compiler-chrome/461JohPKakE/JI3rEBg6FwAJ for more.

BUG=None
TEST='CC=clang CXX=clang++ ./configure && make check'
R=vapier@chromium.org

Review URL: https://codereview.chromium.org/1591793002 .
This commit is contained in:
Mike Frysinger 2016-01-15 13:29:32 -05:00
parent 081cbd64d7
commit 126a938fef
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/processor/range_map-inl.h
View File

@ -50,7 +50,7 @@ template<typename AddressType, typename EntryType>
bool RangeMap<AddressType, EntryType>::StoreRange(const AddressType &base, bool RangeMap<AddressType, EntryType>::StoreRange(const AddressType &base,
const AddressType &size, const AddressType &size,
const EntryType &entry) { const EntryType &entry) {
AddressType high = base + size - 1; AddressType high = base + (size - 1);
// Check for undersize or overflow. // Check for undersize or overflow.
if (size <= 0 || high < base) { if (size <= 0 || high < base) {