From 16cee17997a52e200b38fbded8545bc76127d791 Mon Sep 17 00:00:00 2001 From: Ziad Youssef Date: Fri, 21 Apr 2023 12:47:56 +0000 Subject: [PATCH] Fix alignment of the brief output of minidump_stackwalk Bug: 1435239 Change-Id: I4ea6cbe89d5ef0907f7e07c454e4533995996521 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4459351 Reviewed-by: Joshua Peraza --- src/processor/stackwalk_common.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/processor/stackwalk_common.cc b/src/processor/stackwalk_common.cc index 889931ea..688b2782 100644 --- a/src/processor/stackwalk_common.cc +++ b/src/processor/stackwalk_common.cc @@ -301,7 +301,6 @@ static void PrintFrameHeader(const StackFrame* frame, int frame_index) { } else { printf("0x%" PRIx64, instruction_address); } - printf("\n "); } // PrintStack prints the call stack in |stack| to stdout, in a reasonably @@ -326,6 +325,7 @@ static void PrintStack(const CallStack* stack, for (int frame_index = 0; frame_index < frame_count; ++frame_index) { const StackFrame* frame = stack->frames()->at(frame_index); PrintFrameHeader(frame, frame_index); + printf("\n "); // Inlined frames don't have registers info. if (frame->trust != StackFrameAMD64::FRAME_TRUST_INLINE) { @@ -1297,6 +1297,7 @@ void PrintRequestingThreadBrief(const ProcessState& process_state) { int frame_count = stack->frames()->size(); for (int frame_index = 0; frame_index < frame_count; ++frame_index) { PrintFrameHeader(stack->frames()->at(frame_index), frame_index); + printf("\n"); } }