yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-12-02 22:34:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

linux_core_dumper: add missing newline to Android test-disabled message

Browse Source 
The [       OK ] LinuxCoreDumperTest.VerifyExceptionDetails line does
not appear at the beginning of a line, hiding it from Chromium’s test
infrastructure. This causes the test to have an unknown result, which is
treated as a failure.

https://ci.chromium.org/p/chromium/builders/try/android-kitkat-arm-rel/233129

Bug: google-breakpad:791
Change-Id: I0eb646a219fa40347db884fd28ace647328c5e49
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1558893
Reviewed-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Mark Mentovai 2019-04-08 20:08:59 -04:00
parent 4d550cceca
commit 232c45abee
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/client/linux/minidump_writer/linux_core_dumper_unittest.cc
View File

@ -94,7 +94,7 @@ TEST(LinuxCoreDumperTest, VerifyDumpWithMultipleThreads) {
struct stat st; struct stat st;
if (stat(core_file.c_str(), &st) != 0) { if (stat(core_file.c_str(), &st) != 0) {
fprintf(stderr, "LinuxCoreDumperTest.VerifyDumpWithMultipleThreads test is " fprintf(stderr, "LinuxCoreDumperTest.VerifyDumpWithMultipleThreads test is "
"skipped due to no core file being generated"); "skipped due to no core file being generated\n");
return; return;
} }
#endif #endif
@ -155,7 +155,7 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) {
struct stat st; struct stat st;
if (stat(core_file.c_str(), &st) != 0) { if (stat(core_file.c_str(), &st) != 0) {
fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is " fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is "
"skipped due to no core file being generated"); "skipped due to no core file being generated\n");
return; return;
} }
#endif #endif
@ -170,7 +170,7 @@ TEST(LinuxCoreDumperTest, VerifyExceptionDetails) {
// TODO: For some reason, Android doesn't seem to pass this. // TODO: For some reason, Android doesn't seem to pass this.
if (!dumper.crash_address()) { if (!dumper.crash_address()) {
fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is " fprintf(stderr, "LinuxCoreDumperTest.VerifyExceptionDetails test is "
"skipped due to missing signal details on Android"); "skipped due to missing signal details on Android\n");
return; return;
} }
#endif #endif