From 30153b4eb581710faa298ee35f027dba11f930cc Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Fri, 22 Feb 2019 11:36:53 -0500 Subject: [PATCH] breakpad: Remove semicolons, mac edition. Bug: chromium:926235 Change-Id: I473a7727c1831717b92a582c50d98256ea41d854 Reviewed-on: https://chromium-review.googlesource.com/c/1482716 Reviewed-by: Mark Mentovai --- src/client/mac/Framework/Breakpad.mm | 2 +- src/client/mac/Framework/OnDemandServer.h | 2 +- src/client/mac/Framework/OnDemandServer.mm | 2 +- src/client/mac/crash_generation/ConfigFile.h | 4 ++-- src/client/mac/crash_generation/Inspector.h | 4 ++-- src/common/mac/MachIPC.h | 2 +- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/client/mac/Framework/Breakpad.mm b/src/client/mac/Framework/Breakpad.mm index 1d2e519b..b2140549 100644 --- a/src/client/mac/Framework/Breakpad.mm +++ b/src/client/mac/Framework/Breakpad.mm @@ -117,7 +117,7 @@ class ProtectedMemoryLocker { // Then unlock the mutex __attribute__((unused)) int rv = pthread_mutex_unlock(mutex_); assert(rv == 0); - }; + } private: ProtectedMemoryLocker(); diff --git a/src/client/mac/Framework/OnDemandServer.h b/src/client/mac/Framework/OnDemandServer.h index b8aabbe4..d4db5d3a 100644 --- a/src/client/mac/Framework/OnDemandServer.h +++ b/src/client/mac/Framework/OnDemandServer.h @@ -127,7 +127,7 @@ class OnDemandServer { // This is the port we need to send a mach message to after calling // LaunchOnDemand(). Sending a message causing an immediate launch // of the server - mach_port_t GetServicePort() { return service_port_; }; + mach_port_t GetServicePort() { return service_port_; } private: // Disallow copy constructor diff --git a/src/client/mac/Framework/OnDemandServer.mm b/src/client/mac/Framework/OnDemandServer.mm index dbe601bb..a2ffa434 100644 --- a/src/client/mac/Framework/OnDemandServer.mm +++ b/src/client/mac/Framework/OnDemandServer.mm @@ -71,7 +71,7 @@ OnDemandServer *OnDemandServer::Create(const char *server_command, delete server; return NULL; -}; +} //============================================================================== kern_return_t OnDemandServer::Initialize(const char *server_command, diff --git a/src/client/mac/crash_generation/ConfigFile.h b/src/client/mac/crash_generation/ConfigFile.h index 5662e8b0..f2da7c24 100644 --- a/src/client/mac/crash_generation/ConfigFile.h +++ b/src/client/mac/crash_generation/ConfigFile.h @@ -44,10 +44,10 @@ class ConfigFile { config_file_ = -1; config_file_path_[0] = 0; has_created_file_ = false; - }; + } ~ConfigFile() { - }; + } void WriteFile(const char* directory, const SimpleStringDictionary *configurationParameters, diff --git a/src/client/mac/crash_generation/Inspector.h b/src/client/mac/crash_generation/Inspector.h index 67123551..7f923ed6 100644 --- a/src/client/mac/crash_generation/Inspector.h +++ b/src/client/mac/crash_generation/Inspector.h @@ -98,7 +98,7 @@ class MinidumpLocation { (MinidumpGenerator::UniqueNameInDirectory(dump_path, &next_minidump_id)); strlcpy(minidump_id_, next_minidump_id.c_str(), sizeof(minidump_id_)); - }; + } const char *GetPath() { return minidump_dir_path_; } const char *GetID() { return minidump_id_; } @@ -111,7 +111,7 @@ class MinidumpLocation { //============================================================================= class Inspector { public: - Inspector() {}; + Inspector() {} // given a bootstrap service name, receives mach messages // from a crashed process, then inspects it, creates a minidump file diff --git a/src/common/mac/MachIPC.h b/src/common/mac/MachIPC.h index 8df9165b..71419be9 100644 --- a/src/common/mac/MachIPC.h +++ b/src/common/mac/MachIPC.h @@ -236,7 +236,7 @@ class MachMessage { //============================================================================== class MachReceiveMessage : public MachMessage { public: - MachReceiveMessage() : MachMessage() {}; + MachReceiveMessage() : MachMessage() {} }; //==============================================================================