yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-30 19:54:18 +01:00
Code Issues Packages Projects Releases Wiki Activity

linux: fix broken tests

Browse Source 
Fixes errors for comparisons between signed and unsigned ints.

Change-Id: I7ef151ba84a48a0c8cc449cfaf12b9fef775d5a7
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1642361
Reviewed-by: Mark Mentovai <mark@chromium.org>
This commit is contained in:
Joshua Peraza 2019-06-03 16:59:11 -07:00
parent e436b07330
commit 6f287a5f57
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/client/linux/handler/exception_handler_unittest.cc
View File

@ -887,13 +887,13 @@ TEST(ExceptionHandlerTest, InstructionPointerMemoryNullPointer) {
uint64_t instruction_pointer; uint64_t instruction_pointer;
ASSERT_TRUE(exception_context->GetInstructionPointer(&instruction_pointer)); ASSERT_TRUE(exception_context->GetInstructionPointer(&instruction_pointer));
EXPECT_EQ(instruction_pointer, 0); EXPECT_EQ(instruction_pointer, 0u);
MinidumpMemoryList* memory_list = minidump.GetMemoryList(); MinidumpMemoryList* memory_list = minidump.GetMemoryList();
ASSERT_TRUE(memory_list); ASSERT_TRUE(memory_list);
unsigned int region_count = memory_list->region_count(); unsigned int region_count = memory_list->region_count();
ASSERT_GE(region_count, 1); ASSERT_GE(region_count, 1u);
for (unsigned int region_index = 0; for (unsigned int region_index = 0;
region_index < region_count; region_index < region_count;

4
src/client/linux/minidump_writer/linux_ptrace_dumper_unittest.cc
View File

@ -426,7 +426,7 @@ TEST_F(LinuxPtraceDumperChildTest, FileIDsMatch) {
#undef TestBody #undef TestBody
TEST(LinuxPtraceDumperTest, VerifyStackReadWithMultipleThreads) { TEST(LinuxPtraceDumperTest, VerifyStackReadWithMultipleThreads) {
static const int kNumberOfThreadsInHelperProgram = 5; static const size_t kNumberOfThreadsInHelperProgram = 5;
pid_t child_pid = SetupChildProcess(kNumberOfThreadsInHelperProgram); pid_t child_pid = SetupChildProcess(kNumberOfThreadsInHelperProgram);
ASSERT_NE(child_pid, -1); ASSERT_NE(child_pid, -1);
@ -484,7 +484,7 @@ TEST(LinuxPtraceDumperTest, VerifyStackReadWithMultipleThreads) {
} }
TEST_F(LinuxPtraceDumperTest, SanitizeStackCopy) { TEST_F(LinuxPtraceDumperTest, SanitizeStackCopy) {
static const int kNumberOfThreadsInHelperProgram = 1; static const size_t kNumberOfThreadsInHelperProgram = 1;
pid_t child_pid = SetupChildProcess(kNumberOfThreadsInHelperProgram); pid_t child_pid = SetupChildProcess(kNumberOfThreadsInHelperProgram);
ASSERT_NE(child_pid, -1); ASSERT_NE(child_pid, -1);