yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-24 05:15:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add error messages on pdb Open function

Browse Source 
This implements the error messages from
https://docs.microsoft.com/en-us/visualstudio/debugger/debug-interface-access/idiadatasource-loaddataforexe?view=vs-2022
and
https://docs.microsoft.com/en-us/visualstudio/debugger/debug-interface-access/idiadatasource-loaddatafrompdb?view=vs-2022
instead of having just a generic error message.

Signed-off-by: Lorenzo Alberto Maria Ambrosi <lorenzothunder.ambrosi@gmail.com>
Bug: https://bugs.chromium.org/p/google-breakpad/issues/detail?id=866
Change-Id: I23c0e80d31afb402a70cb0cdded78d3d34ac5fff
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3810512
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
This commit is contained in:
Lorenzo Alberto Maria Ambrosi 2022-08-10 03:55:31 +02:00 committed by Mike Frysinger
parent defdcb714e
commit 7e4ea04094
1 changed files with 48 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
src/common/windows/pdb_source_line_writer.cc
View File

@ -209,6 +209,39 @@ void StripLlvmSuffixAndUndecorate(BSTR* name) {
}
}
// Prints the error message related to the error code as seen in
// Microsoft's MSVS documentation for loadDataFromPdb and loadDataForExe.
void PrintOpenError(HRESULT hr, const char* fn_name, const wchar_t* file) {
switch (hr) {
case E_PDB_NOT_FOUND:
fprintf(stderr, "%s: Failed to open %ws, or the file has an "
"invalid format.\n", fn_name, file);
break;
case E_PDB_FORMAT:
fprintf(stderr, "%s: Attempted to access %ws with an obsolete "
"format.\n", fn_name, file);
break;
case E_PDB_INVALID_SIG:
fprintf(stderr, "%s: Signature does not match for %ws.\n", fn_name,
file);
break;
case E_PDB_INVALID_AGE:
fprintf(stderr, "%s: Age does not match for %ws.\n", fn_name, file);
break;
case E_INVALIDARG:
fprintf(stderr, "%s: Invalid parameter for %ws.\n", fn_name, file);
break;
case E_UNEXPECTED:
fprintf(stderr, "%s: Data source has already been prepared for %ws.\n",
fn_name, file);
break;
default:
fprintf(stderr, "%s: Unexpected error 0x%lx, file: %ws.\n",
fn_name, hr, file);
break;
}
}
} // namespace
PDBSourceLineWriter::Inline::Inline(int inline_nest_level)
@ -400,25 +433,32 @@ bool PDBSourceLineWriter::Open(const wstring& file, FileFormat format) {
return false;
}
HRESULT from_pdb_result;
HRESULT for_exe_result;
const wchar_t* file_name = file.c_str();
switch (format) {
case PDB_FILE:
if (FAILED(data_source->loadDataFromPdb(file.c_str()))) {
fprintf(stderr, "loadDataFromPdb failed for %ws\n", file.c_str());
from_pdb_result = data_source->loadDataFromPdb(file_name);
if (FAILED(from_pdb_result)) {
PrintOpenError(from_pdb_result, "loadDataFromPdb", file_name);
return false;
}
break;
case EXE_FILE:
if (FAILED(data_source->loadDataForExe(file.c_str(), NULL, NULL))) {
fprintf(stderr, "loadDataForExe failed for %ws\n", file.c_str());
for_exe_result = data_source->loadDataForExe(file_name, NULL, NULL);
if (FAILED(for_exe_result)) {
PrintOpenError(for_exe_result, "loadDataForExe", file_name);
return false;
}
code_file_ = file;
break;
case ANY_FILE:
if (FAILED(data_source->loadDataFromPdb(file.c_str()))) {
if (FAILED(data_source->loadDataForExe(file.c_str(), NULL, NULL))) {
fprintf(stderr, "loadDataForPdb and loadDataFromExe failed for %ws\n",
file.c_str());
from_pdb_result = data_source->loadDataFromPdb(file_name);
if (FAILED(from_pdb_result)) {
for_exe_result = data_source->loadDataForExe(file_name, NULL, NULL);
if (FAILED(for_exe_result)) {
PrintOpenError(from_pdb_result, "loadDataFromPdb", file_name);
PrintOpenError(for_exe_result, "loadDataForExe", file_name);
return false;
}
code_file_ = file;