Issue 384 - UnregisterWait error handling is incorrect. Patch by Benjamin Smedberg <benjamin@smedbergs.us>, r=doshimun at http://breakpad.appspot.com/107001

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@603 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
ted.mielczarek 2010-05-19 13:40:59 +00:00
parent 0b54af4f91
commit b0059c54da
2 changed files with 6 additions and 16 deletions

View File

@ -101,26 +101,16 @@ ClientInfo::~ClientInfo() {
}
}
bool ClientInfo::UnregisterWaits() {
bool success = true;
void ClientInfo::UnregisterWaits() {
if (dump_request_wait_handle_) {
if (!UnregisterWait(dump_request_wait_handle_)) {
success = false;
} else {
dump_request_wait_handle_ = NULL;
}
UnregisterWait(dump_request_wait_handle_);
dump_request_wait_handle_ = NULL;
}
if (process_exit_wait_handle_) {
if (!UnregisterWait(process_exit_wait_handle_)) {
success = false;
} else {
process_exit_wait_handle_ = NULL;
}
UnregisterWait(process_exit_wait_handle_);
process_exit_wait_handle_ = NULL;
}
return success;
}
bool ClientInfo::GetClientExceptionInfo(EXCEPTION_POINTERS** ex_info) const {

View File

@ -83,7 +83,7 @@ class ClientInfo {
}
// Unregister all waits for the client.
bool UnregisterWaits();
void UnregisterWaits();
bool Initialize();
bool GetClientExceptionInfo(EXCEPTION_POINTERS** ex_info) const;