From b2831dbed17a506eda8228ab1a0ecff70af56e9d Mon Sep 17 00:00:00 2001 From: John Z Wu Date: Mon, 13 May 2019 13:11:05 -0700 Subject: [PATCH] Increase timeout of HTTPMultipartUpload from 10s to 60s. This, hopefully, will reduce occurrences of UnfinishedReportUploads. It will not eliminate it completely because uploads are never retried if they fail. 60s is actually the default value. Before iOS6, 240s was the default and minimum applied to requests with a body. Reference: https://developer.apple.com/documentation/foundation/nsmutableurlrequest/1414063-timeoutinterval?language=objc Bug:850379 Change-Id: I2f16fda7d7e8cbb8b8a6fc917111d9f646fbdad0 Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1609876 Reviewed-by: Mark Mentovai --- src/common/mac/HTTPMultipartUpload.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/common/mac/HTTPMultipartUpload.m b/src/common/mac/HTTPMultipartUpload.m index f6d081e4..a3677f25 100644 --- a/src/common/mac/HTTPMultipartUpload.m +++ b/src/common/mac/HTTPMultipartUpload.m @@ -203,7 +203,7 @@ static NSData *SendSynchronousNSURLRequest(NSURLRequest *req, NSMutableURLRequest *req = [[NSMutableURLRequest alloc] initWithURL:url_ cachePolicy:NSURLRequestUseProtocolCachePolicy - timeoutInterval:10.0 ]; + timeoutInterval:60.0]; NSMutableData *postBody = [NSMutableData data];