From b5c662fcfe521f3f026329effa5d647534aa776a Mon Sep 17 00:00:00 2001 From: "rmcilroy@chromium.org" Date: Mon, 22 Sep 2014 16:56:20 +0000 Subject: [PATCH] Fix clang compilation error introduced in r1380. Fixes: .../linux_dumper.cc:308:25: error: address of array 'module->name' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion] module->name && module->name[0] == '/' && ~~~~~~~~^~~~ BUG=chromium:394703 R=rmcilroy@chromium.org Review URL: https://breakpad.appspot.com/5724002 Patch from Simon Baldwin . git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1384 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/linux/minidump_writer/linux_dumper.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/linux/minidump_writer/linux_dumper.cc b/src/client/linux/minidump_writer/linux_dumper.cc index 2f17c649..d565c741 100644 --- a/src/client/linux/minidump_writer/linux_dumper.cc +++ b/src/client/linux/minidump_writer/linux_dumper.cc @@ -305,7 +305,7 @@ bool LinuxDumper::EnumerateMappings() { MappingInfo* module = mappings_.back(); if ((start_addr == module->start_addr + module->size) && module->exec && - module->name && module->name[0] == '/' && + module->name[0] == '/' && offset == 0 && my_strncmp(i2, kReservedFlags, sizeof(kReservedFlags) - 1) == 0) {