yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-24 07:45:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix windows symbol converter blacklisting.

Browse Source 
- Was attempting "full match" when we meant to do "partial match".

Change-Id: Ia748a7fc8707e11f44c205e57f218f5f4bbc5612
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1676936
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
This commit is contained in:
Nelson Billing 2019-06-25 15:56:50 -07:00
parent e1b5fef027
commit b62101dead
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/tools/windows/converter_exe/converter.cc
View File

@ -276,11 +276,12 @@ static bool SendFetchFailedPing(const wstring &fetch_symbol_failure_url,
// external request unless the symbol file's debug_file string matches // external request unless the symbol file's debug_file string matches
// the given blacklist regular expression. // the given blacklist regular expression.
// The debug_file name is used from the MissingSymbolInfo struct, // The debug_file name is used from the MissingSymbolInfo struct,
// matched against the PCRE blacklist_regex. // matched against the blacklist_regex.
static bool SafeToMakeExternalRequest(const MissingSymbolInfo &missing_info, static bool SafeToMakeExternalRequest(const MissingSymbolInfo &missing_info,
std::regex blacklist_regex) { std::regex blacklist_regex) {
string file_name = missing_info.debug_file; string file_name = missing_info.debug_file;
if (std::regex_match(file_name, blacklist_regex)) { // Use regex_search because we want to match substrings.
if (std::regex_search(file_name, blacklist_regex)) {
FprintfFlush(stderr, "Not safe to make external request for file %s\n", FprintfFlush(stderr, "Not safe to make external request for file %s\n",
file_name.c_str()); file_name.c_str());
return false; return false;