From b62d01462c23676335eb09c0e0b988967d67b387 Mon Sep 17 00:00:00 2001 From: "ted.mielczarek" Date: Thu, 5 Jul 2007 22:13:02 +0000 Subject: [PATCH] Issue 175 - fix permissions on dump file in MinidumpFileWriter. r=mento git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@197 4c0a9323-5329-0410-9bdc-e9ce6186880e --- src/client/minidump_file_writer.cc | 2 +- src/client/windows/handler/exception_handler.cc | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/client/minidump_file_writer.cc b/src/client/minidump_file_writer.cc index a4816d1a..fdd59198 100644 --- a/src/client/minidump_file_writer.cc +++ b/src/client/minidump_file_writer.cc @@ -53,7 +53,7 @@ MinidumpFileWriter::~MinidumpFileWriter() { bool MinidumpFileWriter::Open(const char *path) { assert(file_ == -1); - file_ = open(path, O_WRONLY | O_CREAT | O_TRUNC, 0666); + file_ = open(path, O_WRONLY | O_CREAT | O_EXCL, 0600); return file_ != -1; } diff --git a/src/client/windows/handler/exception_handler.cc b/src/client/windows/handler/exception_handler.cc index 9a9d5266..4bb67b21 100644 --- a/src/client/windows/handler/exception_handler.cc +++ b/src/client/windows/handler/exception_handler.cc @@ -452,9 +452,9 @@ bool ExceptionHandler::WriteMinidumpWithException( if (minidump_write_dump_) { HANDLE dump_file = CreateFile(next_minidump_path_c_, GENERIC_WRITE, - FILE_SHARE_WRITE, + 0, // no sharing NULL, - CREATE_ALWAYS, + CREATE_NEW, // fail if exists FILE_ATTRIBUTE_NORMAL, NULL); if (dump_file != INVALID_HANDLE_VALUE) {