From c5ceea7d74ea8e5e5af543ace053806afb153a2d Mon Sep 17 00:00:00 2001 From: "ivan.penkov@gmail.com" Date: Fri, 29 Mar 2013 21:37:42 +0000 Subject: [PATCH] Removing redundant calls to string::c_str(). https://breakpad.appspot.com/539002/ git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1139 4c0a9323-5329-0410-9bdc-e9ce6186880e --- .../minidump_writer/minidump_writer_unittest.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/client/linux/minidump_writer/minidump_writer_unittest.cc b/src/client/linux/minidump_writer/minidump_writer_unittest.cc index ace7f350..7d6b8667 100644 --- a/src/client/linux/minidump_writer/minidump_writer_unittest.cc +++ b/src/client/linux/minidump_writer/minidump_writer_unittest.cc @@ -199,7 +199,7 @@ TEST(MinidumpWriterTest, MappingInfo) { // Read the minidump. Load the module list, and ensure that // the mmap'ed |memory| is listed with the given module name // and debug ID. - Minidump minidump(templ.c_str()); + Minidump minidump(templ); ASSERT_TRUE(minidump.Read()); MinidumpModuleList* module_list = minidump.GetModuleList(); @@ -318,7 +318,7 @@ TEST(MinidumpWriterTest, MappingInfoContained) { // Read the minidump. Load the module list, and ensure that // the mmap'ed |memory| is listed with the given module name // and debug ID. - Minidump minidump(dumpfile.c_str()); + Minidump minidump(dumpfile); ASSERT_TRUE(minidump.Read()); MinidumpModuleList* module_list = minidump.GetModuleList(); @@ -400,7 +400,7 @@ TEST(MinidumpWriterTest, DeletedBinary) { ASSERT_EQ(0, stat(templ.c_str(), &st)); ASSERT_GT(st.st_size, 0); - Minidump minidump(templ.c_str()); + Minidump minidump(templ); ASSERT_TRUE(minidump.Read()); // Check that the main module filename is correct. @@ -481,7 +481,7 @@ TEST(MinidumpWriterTest, AdditionalMemory) { mappings, memory_list)); // Read the minidump. Ensure that the memory region is present - Minidump minidump(templ.c_str()); + Minidump minidump(templ); ASSERT_TRUE(minidump.Read()); MinidumpMemoryList* dump_memory_list = minidump.GetMemoryList(); @@ -551,7 +551,7 @@ TEST(MinidumpWriterTest, InvalidStackPointer) { ASSERT_TRUE(WriteMinidump(templ.c_str(), child, &context, sizeof(context))); // Read the minidump. Ensure that the memory region is present - Minidump minidump(templ.c_str()); + Minidump minidump(templ); ASSERT_TRUE(minidump.Read()); // TODO(ted.mielczarek,mkrebs): Enable this part of the test once @@ -652,7 +652,7 @@ TEST(MinidumpWriterTest, MinidumpSizeLimit) { ASSERT_GT(st.st_size, 0); normal_file_size = st.st_size; - Minidump minidump(normal_dump.c_str()); + Minidump minidump(normal_dump); ASSERT_TRUE(minidump.Read()); MinidumpThreadList* dump_thread_list = minidump.GetThreadList(); ASSERT_TRUE(dump_thread_list); @@ -719,7 +719,7 @@ TEST(MinidumpWriterTest, MinidumpSizeLimit) { // in like it was supposed to. EXPECT_LT(st.st_size, normal_file_size); - Minidump minidump(limit_dump.c_str()); + Minidump minidump(limit_dump); ASSERT_TRUE(minidump.Read()); MinidumpThreadList* dump_thread_list = minidump.GetThreadList(); ASSERT_TRUE(dump_thread_list);