From c83fcf647033cd31348b4109c2a9d8df72706361 Mon Sep 17 00:00:00 2001 From: Sergey Abbakumov Date: Tue, 10 Apr 2018 10:09:44 +0700 Subject: [PATCH] Initialize variables for MSAN The variables in the CL are not initialized. Even if it's safe not to initialize them here, MSAN doesn't know that. Bug: 394028 Change-Id: I597a7d76aa19d5789decd0f85150fa31c9655269 Reviewed-on: https://chromium-review.googlesource.com/1001573 Reviewed-by: Lei Zhang --- src/client/linux/handler/exception_handler.cc | 2 +- src/client/linux/handler/exception_handler.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/client/linux/handler/exception_handler.cc b/src/client/linux/handler/exception_handler.cc index a41e8c58..b895f6d7 100644 --- a/src/client/linux/handler/exception_handler.cc +++ b/src/client/linux/handler/exception_handler.cc @@ -549,7 +549,7 @@ bool ExceptionHandler::GenerateDump(CrashContext *context) { // Allow the child to ptrace us sys_prctl(PR_SET_PTRACER, child, 0, 0, 0); SendContinueSignalToChild(); - int status; + int status = 0; const int r = HANDLE_EINTR(sys_waitpid(child, &status, __WALL)); sys_close(fdes[1]); diff --git a/src/client/linux/handler/exception_handler.h b/src/client/linux/handler/exception_handler.h index d246f601..1695a2b7 100644 --- a/src/client/linux/handler/exception_handler.h +++ b/src/client/linux/handler/exception_handler.h @@ -262,7 +262,7 @@ class ExceptionHandler { // can do this. We create a pipe which we can use to block the // cloned process after creating it, until we have explicitly enabled // ptrace. This is used to store the file descriptors for the pipe - int fdes[2]; + int fdes[2] = {-1, -1}; // Callers can add extra info about mappings for cases where the // dumper code cannot extract enough information from /proc//maps.