ted.mielczarek
0abe34ce5d
issue 305 - breakpad Linux handler doesn't build with compiler built from latest GCC sources. Trivial patch by Jim Blandy
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@321 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-24 19:57:46 +00:00
nealsid
a18f4f9a06
Removing SVN external of GOogle Toolbox for mac, since we only need a few files that don't change very often
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@320 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-23 20:22:45 +00:00
nealsid
3366749ee7
Fix for issue 304: symupload needs to support timeout specifications(wininet can timeout when sending large symbol files).
...
R=doshimun
W=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@319 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-03-20 19:02:12 +00:00
nealsid
2ad976ef0b
Fix for issues 296, 297. Various symbol supplier classes need to be updated with new overload('make check' was failing, as well as crash_report), and remove logging that was flooding output
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@318 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-27 23:59:40 +00:00
nealsid
02c244f1b2
Fix for issue 242, plus a redo of how old exception handlers are tracked, and called.
...
R=Craig.Schlenter, luly81
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@315 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-26 21:31:53 +00:00
nealsid
4af5fe0b59
Fix build breaks on Solaris using Sun Studio.
...
Written by Ginn Chen & Eagle.Lu@
R=nealsid (although I don't have a Solaris machine to build on, & these changes look localized to Sun-only builds)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@314 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-23 09:28:29 +00:00
nealsid
e1a7efca7d
See https://bugzilla.mozilla.org/show_bug.cgi?id=397200
...
The method of calculating a binary ID using the LC_ID command isn't compatible with non-default build processes, most Mac consumers
use LC_UUID anyway but for those that don't, MD5 is a better choice
R=nealsid
W=Ted.Mielczarek
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@313 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-22 08:16:05 +00:00
nealsid
cadc8ddde9
Issue 294: mmap error checking is not correct.
...
R=Liu
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@312 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-22 01:31:43 +00:00
nealsid
0fd2f1ae21
Modify symbol supplier interface to support an overload that takes a symbol data buffer, to get around an extraneous read/write of symbol data
...
R=doshimun
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@311 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-19 21:26:20 +00:00
nealsid
a285652cba
Issue 275: patch to include list of loaded modules in crash_report output
...
Written by: jum@mac.com
R=nealsid
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@310 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-02-10 21:29:54 +00:00
doshimun
c9944d96e8
Reinstnate the call to TerminateThread inside ExceptionHandler destructor and put
...
the graceful code inside a #ifdef.
The problem is:
If ExceptionHandler is created and destroyed in DllMain, then the previous change to
remove the call to TerminateThread will lead to a deadlock. This is because inside
DllMain the loader lock is acquired, and the previous change waits for the handler
thread to exit in the destructor, that is with the loader lock acquired. But the
handler thread cannot finish until it gets the loader lock to call DllMain for
THREAD_DETACH.
With this change, we add conditional compilation so that clients that want to
avoid the call to terminate thread can do it by defining the appropriate preprocessor
variable.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@309 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-20 20:45:28 +00:00
doshimun
104e4e0114
Fix an AppVerifier STOP in OOP server code. In the destructor of
...
the OOP server, we need to wait for any pending I/O to be done.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@308 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-16 22:37:48 +00:00
doshimun
308947d1ce
Fix some typos in comments.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@307 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-14 21:54:08 +00:00
doshimun
a6f58a1ac8
Minor fixes to windows exception handler.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@306 4c0a9323-5329-0410-9bdc-e9ce6186880e
2009-01-14 20:51:51 +00:00
nealsid
8b6271ce2c
New test data to reflect Ted's changes that add function parameters to symbols when using DWARF
...
R=ted.mielczarek
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@305 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-19 22:28:45 +00:00
nealsid
ab819f0680
Updating externals to include all of Google Toolbox for Mac
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@304 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-11 03:25:39 +00:00
ted.mielczarek
3751b05354
Issue 283 - DWARF dumper doesn't handle DW_AT_specification. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@303 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-08 13:12:45 +00:00
ted.mielczarek
d3441c2c96
Issue 284 - DWARF dumper doesn't output function names including arguments. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@302 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-08 13:00:29 +00:00
ted.mielczarek
7837cb7236
issue 286 - clean up some demangling code in dump_syms.mm. r=chris rogers
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@301 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-03 18:23:09 +00:00
mmentovai
e5c401467b
ExceptionHandler class is not handling initialization errors, such as the
...
handler thread not being created. Protect the exception handler against
failure to create semaphores and a thread handle.
Patch by Marc-André (MAD) Decoste, r=me
http://code.google.com/p/google-breakpad/issues/detail?id=285
http://codereview.chromium.org/13065
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@300 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-03 17:21:34 +00:00
ted.mielczarek
af553e22cb
follow up for issue 281 - dump_syms fails to find dylib symbol file inside of a bundle. handle files without an extension properly
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@299 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-01 18:42:16 +00:00
ted.mielczarek
7b8eb04745
issue 281 - dump_syms fails to find dylib symbol file inside of a bundle. r=nealsid
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@298 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-12-01 17:05:43 +00:00
ted.mielczarek
5f27d9125c
Followup to address some review comments from Issue 259
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@297 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-25 13:41:41 +00:00
ted.mielczarek
324d84c2f6
Issue 259 - crash when generating large .sym files with dump_syms on Linux. Patch by login_ing@yahoo.com, r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@296 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-24 20:47:37 +00:00
nealsid
e055207058
Added some sanity checks when iterating over threads in a crashed process. In same cases the ESP could be 0. In other cases it would be borked completely(i.e. pointing to an invalid range).
...
R=Jeremy Moskovich
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@295 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-19 19:07:34 +00:00
nealsid
f32d028110
Committing an externals directory to pull in google toolbox for mac
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@294 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-14 20:16:13 +00:00
nealsid
c85fb043ed
Fix for dump_syms to ignore line number information for addresses that don't have an enclosing function
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@293 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-11-03 23:23:50 +00:00
nealsid
3a283d8f8b
Undo suspend/resume feature since it was meant as a workaround to a bug in how we handled child process exceptions. Currently we don't return to the kernel when we take an exception from a child process, causing a hang. Now we return KERN_FAILURE, indicating to the kernel to move on to the host-level exception handler(usually Crash Reporter)
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@292 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-27 04:52:16 +00:00
nealsid
32441cc060
Issue 181: Add version info for Mac OS X modules. Found by iterating over load commands until I found LC_ID_DYLIB. Also modified crash_report to generate version number. Also added suspend/resume capability to exception handler, necessary because exception handling can behave strangely across fork() calls. Also added fix for filtering out functions with no line number information, and for filtering out some multiple inheritance glue the compiler generates.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@291 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-22 05:08:50 +00:00
ted.mielczarek
c5f46b2f4b
Issue 276 - generate GUIDs ahead of time in Linux handler. r=Liu Li
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@290 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-14 11:21:34 +00:00
nealsid
1de70760db
Fix for DWARF processing when inline functions were encountered. Inline functions were part of the debugging information as sequential in the PC range of the function but the source file was where the function was written(as you might expect). However the old dump_syms code, once it switched files as it was iterating over a range of addresses, never switched back, causing inline functions to cause all file numbers for addresses after the PC of the inline function to be wrong
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@289 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-14 01:24:02 +00:00
nealsid
bb067bf185
Fix warning when converting int to bool
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@288 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-10 17:51:32 +00:00
ted.mielczarek
596e476fc2
fix a typo in the makefile, HANDLER_SRC->HANDLER_OBJ
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@287 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-10 15:48:06 +00:00
nealsid
cb4aa6b804
Added DWARF support to Breakpad client. Thanks to Google for open sourcing their DWARF code!
...
Modified dump_syms to detect dSYM bundles or a binary with DWARF data appropriately, and convert data from DWARF reader to dump_syms native structures
R=danny.berlin (original writer of DWARF code)
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@286 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-10-08 23:56:02 +00:00
mmentovai
a509f4ec4b
Generate Windows full memory dumps as a separate file. Patch by Huan Ren
...
<huanr@google.com>. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@285 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-09-16 18:50:02 +00:00
mmentovai
9fcf4db315
Include what you use: include <algorithm> and <string.h> as needed. Patch by
...
Robert Henry. r=me
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@284 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-09-15 18:16:49 +00:00
doshimun
11dc028694
Log a failure message in case of LOCATE_NOT_FOUND error.
...
Without this change, no error is logged in this case.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@283 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-07-30 19:39:48 +00:00
nealsid
85534c2eaf
Now we provide our own implementation of the MIG function exc_server, as recommended by Apple.
...
See
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/8b363b1f8a404714
For more information
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@282 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-07-11 17:39:52 +00:00
doshimun
2d7664e8d4
In the destructor of ClientInfo, currently the wait on the clent_crashed_event is
...
unregistered after the handle is closed. MSDN clearly says that the behavior is
undefined in this case. See http://msdn.microsoft.com/en-us/library/ms685061(VS.85).aspx
This change contains the fix for that bug. See attched diff.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@281 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-09 23:38:24 +00:00
doshimun
3a516e4177
Client process uptime is a very useful metric for crashes. Instead of each client process having to keep track of uptime and report it whenever a crash happens, integrate this feature into breakpad OOP code so that all clients get it for free.
...
I tested this using the test app I have to test OOP stuff.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@280 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-06 21:41:32 +00:00
nealsid
38bc56cfa8
Modified symupload to correctly handle spaces in module names when processing symbol file
...
Reviewer=mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@279 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-05 21:20:53 +00:00
doshimun
cc6cd1ff37
Fix the following bug:
...
The sender updates the checkpoint file even when the report is not
successfully sent.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@278 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-05 20:59:35 +00:00
nealsid
d55398a492
Filter out duplicates from the image list when creating a minidump. See issue 266 for more details.
...
Reviewer = mmentovai
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@277 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-06-04 22:57:09 +00:00
doshimun
f6b3e16ef8
Set the dump thread id and the requesting thread id properties of MDRawBreakpadInfo
...
only in case of in-process dump generation; otherwise the dump processing code of
breakpad doesn't identify the crashing thread properly.
I am checking this in to-be-reviewed since it is needed urgently in one of the
products at Google.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@276 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-31 19:23:20 +00:00
nealsid
b91bb881d5
Fix to ignore source files that have a text address of 0 in their stabs entry
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@275 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-19 17:27:40 +00:00
doshimun
72bafd378d
Microsoft broke PROCESS_ALL_ACCESS when we build with WINVER=0x600. See http://nsylvain.blogspot.com/2008/01/winverwin32winnt-mayhem.html for
...
details (second half of the post).
Changing PROCESS_ALL_ACCESS to GENERIC_ALL in ClientInfo class when
opening the client process handle on the OOP server side.
A minor change to pipe name in the test app also.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@274 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-15 04:12:34 +00:00
mmentovai
808ff9bc70
64-bit processor can't handle 32-bit ppc minidumps due to struct padding
...
differences on 64- and 32-bit CPUs. Force 32-bit alignment rules for
32-bit ppc context struct. r=nealsid
http://groups.google.com/group/google-breakpad-dev/browse_thread/thread/21a8e99c4800b51d
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@273 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-14 18:24:23 +00:00
nealsid
d318f9efee
Fix to stop unit tests from being compiled & run for non-native architectures
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@272 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-08 23:15:00 +00:00
doshimun
7ab126ecdd
Replace the user of wcscpy_s with safe_wcscpy in common/windows/string_utils-inl.h to
...
make the code compatible for teams that still use VS 2003 to build.
Fix a bug in client ClientInfo class that returned CustomClientInfo struct containing
a pointer in the client process address space instead of pointer to in-process data
structure.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@271 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-08 18:15:07 +00:00
doshimun
8602aa71ec
Some style guide compliance changes and changed the prototype of the method to get custom client info in ClientInfo class.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@270 4c0a9323-5329-0410-9bdc-e9ce6186880e
2008-05-07 21:54:12 +00:00