yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-28 00:14:14 +01:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of Google Breakpad project
2,015 Commits 1 Branch 0 Tags 15 MiB
C++ 70.3%
Makefile 13.4%
C 5%
Shell 4.4%
Objective-C 3.1%
Other 3.7%
0c816d2d12
Go to file
George Burgess IV 0c816d2d12 module_unittest: fix use-after-free 
`Construct.FunctionsWithSameAddress` started failing at ff5892c5. It
looks like the cause of this is in the calls to
`generate_duplicate_function`:

```
generate_duplicate_function("_without_form");
generate_duplicate_function("_and_void");
```

`generate_duplicate_function` directly calls `new
Module::Function(...);`, which stores the `StringView` it's given.
`generate_duplicate_function` currently takes a `const
string &`; in the above statements, these strings get `free()`d at the
`;`.

Making the parameter a `StringView` means the `Module::Function` will
store pointers to the string literal, which lives for the whole program.

All calls to `generate_duplicate_function` are given literals.

Bug: b:235999011
Change-Id: Ied04c1307a2467b9816a83f0c4d84d47779ec610
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3726855
Reviewed-by: Mike Frysinger <vapier@chromium.org>
2022-06-27 20:59:02 +00:00
.github/workflows github: update to latest coverity scan action 2022-02-08 17:27:36 +00:00
android Use breakpad_getcontext on all Linux platforms missing getcontext 2020-03-16 21:27:07 +00:00
autotools Fix Travis build by running tests as root 2018-02-20 11:08:52 +00:00
docs Add docs for INLINE and INLINE_ORIGIN in overview 2022-03-14 22:47:01 +00:00
m4 Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
src module_unittest: fix use-after-free 2022-06-27 20:59:02 +00:00
.clang-format Add a .clang-format file to give us local control over Chromium style. 2020-08-31 18:46:34 +00:00
.gitignore Add core_handler and pid2md into git ignore 2021-02-06 15:06:11 +00:00
aclocal.m4 Reland "Support PE modules in core files when running core2md" 2022-06-08 19:59:24 +00:00
appveyor.yml Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00
AUTHORS
breakpad-client.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
breakpad.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
ChangeLog
codereview.settings codereview.settings: do not force squashing behavior 2019-08-14 17:56:21 +00:00
configure Update Rust demangling to use rustc-demangle 2021-11-11 02:02:49 +00:00
configure.ac Update Rust demangling to use rustc-demangle 2021-11-11 02:02:49 +00:00
default.xml gtest: update to 1.11 release 2021-10-14 15:56:05 +00:00
DEPS gtest: update to 1.11 release 2021-10-14 15:56:05 +00:00
DIR_METADATA add DIR_METADATA settings 2021-11-25 04:02:40 +00:00
INSTALL autoreconf -f -i 2013-12-10 17:53:50 +00:00
LICENSE There are source files with APSL-2.0 as well. 2020-07-17 01:32:59 +00:00
Makefile.am Reland "Support PE modules in core files when running core2md" 2022-06-08 19:59:24 +00:00
Makefile.in Reland "Support PE modules in core files when running core2md" 2022-06-08 19:59:24 +00:00
NEWS
OWNERS add OWNERS settings 2021-06-03 16:26:13 +00:00
README.ANDROID Update symbol file documentation links. 2016-06-10 06:29:06 -04:00
README.md CI: convert Travis to GH actions 2021-10-14 09:00:39 +00:00

README.md

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from main)

  1. First, download depot_tools and ensure that they’re in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad

  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
cd src

  4. Build the source.

    ./configure && make

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check

  6. Optionally, install the built libraries

    make install

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.