Mirror of Google Breakpad project
Go to file
Mike Frysinger 0e45a1268a macho_reader_unittest: use EXPECT_FALSE
This avoids compile time errors:
In file included from ./src/testing/googletest/include/gtest/gtest.h:1874:0,
                 from ./src/breakpad_googletest_includes.h:33,
                 from src/common/mac/macho_reader_unittest.cc:39:
src/common/mac/macho_reader_unittest.cc: In member function 'virtual void LoadCommand_SegmentBE32_Test::TestBody()':
./src/testing/googletest/include/gtest/internal/gtest-internal.h:133:55: error:
  converting 'false' to pointer type for argument 1 of 'char testing::internal::IsNullLiteralHelper(testing::internal::Secret*)' [-Werror=conversion-null]
     (sizeof(::testing::internal::IsNullLiteralHelper(x)) == 1)
                                                       ^
...
src/common/mac/macho_reader_unittest.cc:1117:3: note: in expansion of macro 'EXPECT_EQ'
   EXPECT_EQ(false,                        actual_segment.bits_64);

Change-Id: I0cf88160dbe17b0feebed3c91ad65491b81023fd
Reviewed-on: https://chromium-review.googlesource.com/439004
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-02-12 18:51:38 +00:00
android sample_app: enable C++11 for Android builds 2016-04-04 21:35:26 -04:00
autotools autotools: refresh config.{sub,guess} 2017-02-06 13:57:59 -05:00
docs Update links 2016-11-18 17:24:37 +00:00
m4 aclocal: regenerate properly 2017-02-08 19:52:52 +00:00
scripts travis: note misbehavior by coverity addon when throttled 2016-06-24 05:09:28 -04:00
src macho_reader_unittest: use EXPECT_FALSE 2017-02-12 18:51:38 +00:00
.gitignore GitIgnore: Add dump_syms_mac 2016-11-14 20:16:05 +00:00
.travis.yml travis: add coverity scan integration 2016-06-21 11:14:28 -04:00
aclocal.m4 aclocal: regenerate properly 2017-02-08 19:52:52 +00:00
AUTHORS
breakpad-client.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
breakpad.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
ChangeLog
codereview.settings Switch to Gerrit for code reviews 2016-07-27 20:07:49 +00:00
configure aclocal: regenerate properly 2017-02-08 19:52:52 +00:00
configure.ac aclocal: regenerate properly 2017-02-08 19:52:52 +00:00
default.xml Upgrade google test to 1.8.0 2016-11-23 23:04:33 +00:00
DEPS Upgrade google test to 1.8.0 2016-11-23 23:04:33 +00:00
INSTALL autoreconf -f -i 2013-12-10 17:53:50 +00:00
LICENSE Renaming file COPYING to LICENSE and appending the disclaimer from src/common/convert_UTF.h to LICENSE. 2014-02-27 19:23:16 +00:00
Makefile.am microdump_stackwalk_test: fix bashism in test 2016-11-25 04:53:01 +00:00
Makefile.in aclocal: regenerate properly 2017-02-08 19:52:52 +00:00
NEWS
README.ANDROID Update symbol file documentation links. 2016-06-10 06:29:06 -04:00
README.md Switch to Gerrit for code reviews 2016-07-27 20:07:49 +00:00

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from master)

  1. First, download depot_tools and ensure that theyre in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad
    
  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
    cd src
    
  4. Build the source.

    ./configure && make
    

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check
    
  6. Optionally, install the built libraries

    make install
    

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CCd.