Mirror of Google Breakpad project
Go to file
Justin Cohen 0f1f43edd2 Revert "Support PE modules in core files when running core2md"
This reverts commit 0808030bee.

Reason for revert: Breaks Android Compile

ld.lld: error: undefined symbol: google_breakpad::PEFile::TryGetDebugInfo(char const*, google_breakpad::_RSDS_DEBUG_FORMAT*)
>>> referenced by minidump_writer.cc
>>>               client/minidump_writer.o:((anonymous namespace)::MinidumpWriter::FillRawModule(google_breakpad::MappingInfo const&, bool, unsigned int, MDRawModule*, unsigned char const*)) in archive obj/third_party/breakpad/libclient.a


https://ci.chromium.org/ui/p/chromium/builders/try/android-marshmallow-arm64-rel/1188618/overview

Original change's description:
> Support PE modules in core files when running core2md
>
> Core files generated from `wine` contain both ELF and PE modules. Module
> format can be guessed by checking the file contents. If the module
> corresponds to PE-file conditions (has specific fields set up as
> described in https://code.google.com/archive/p/corkami/wikis/PE.wiki)
> we'll create a MDCVInfoPDB70 record in the minidump for it, but if
> the file cannot be opened, is too short or is not a PE file, we'll
> fall back to ELF procedure.
>
> Added /src/client/linux/minidump_writer/pe_file.{cc,h} to
> src_client_linux_libbreakpad_client_a_SOURCES and
> src_client_linux_linux_client_unittest_shlib_SOURCES.
> Makefile.in and aclocal.m4 were generated by running 'aclocal && automake'.
>
> Test: build core2md and use it to convert a core file into dmp, validate
> that the generated dmp file can be opened. Ran './configure & make'.
>
> Change-Id: I225ffeea3f582deed40ecdfe7ab77f5754e90cbe
> Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3629189
> Reviewed-by: Joshua Peraza <jperaza@chromium.org>

Change-Id: I7105ed615a338263f112243bd8dc9e86b906fcb1
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3695862
Reviewed-by: Ivan Penkov <ivanpe@chromium.org>
2022-06-08 18:11:47 +00:00
.github/workflows github: update to latest coverity scan action 2022-02-08 17:27:36 +00:00
android Use breakpad_getcontext on all Linux platforms missing getcontext 2020-03-16 21:27:07 +00:00
autotools Fix Travis build by running tests as root 2018-02-20 11:08:52 +00:00
docs Add docs for INLINE and INLINE_ORIGIN in overview 2022-03-14 22:47:01 +00:00
m4 Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
src Revert "Support PE modules in core files when running core2md" 2022-06-08 18:11:47 +00:00
.clang-format Add a .clang-format file to give us local control over Chromium style. 2020-08-31 18:46:34 +00:00
.gitignore Add core_handler and pid2md into git ignore 2021-02-06 15:06:11 +00:00
aclocal.m4 Revert "Support PE modules in core files when running core2md" 2022-06-08 18:11:47 +00:00
appveyor.yml Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00
AUTHORS Make build system less annoying (#8) r=bryner 2006-08-30 20:05:05 +00:00
breakpad-client.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
breakpad.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
ChangeLog Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
codereview.settings codereview.settings: do not force squashing behavior 2019-08-14 17:56:21 +00:00
configure Update Rust demangling to use rustc-demangle 2021-11-11 02:02:49 +00:00
configure.ac Update Rust demangling to use rustc-demangle 2021-11-11 02:02:49 +00:00
default.xml gtest: update to 1.11 release 2021-10-14 15:56:05 +00:00
DEPS gtest: update to 1.11 release 2021-10-14 15:56:05 +00:00
DIR_METADATA add DIR_METADATA settings 2021-11-25 04:02:40 +00:00
INSTALL autoreconf -f -i 2013-12-10 17:53:50 +00:00
LICENSE There are source files with APSL-2.0 as well. 2020-07-17 01:32:59 +00:00
Makefile.am Revert "Support PE modules in core files when running core2md" 2022-06-08 18:11:47 +00:00
Makefile.in Revert "Support PE modules in core files when running core2md" 2022-06-08 18:11:47 +00:00
NEWS Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
OWNERS add OWNERS settings 2021-06-03 16:26:13 +00:00
README.ANDROID Update symbol file documentation links. 2016-06-10 06:29:06 -04:00
README.md CI: convert Travis to GH actions 2021-10-14 09:00:39 +00:00

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from main)

  1. First, download depot_tools and ensure that theyre in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad
    
  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
    cd src
    
  4. Build the source.

    ./configure && make
    

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check
    
  6. Optionally, install the built libraries

    make install
    

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CCd.