breakpad/src
ted.mielczarek 6869f2e1b3 Breakpad DWARF CFI parser: Use the proper type for offsets in CallFrameInfo::Rule subclasses.
The subclasses of CallFrameInfo::Rule store the rule currently in
force for recovering a register or computing the canonical frame
address. Their sole responsibility is to accurately convey rules from
the parser, which creates them, to a CallFrameInfo::Handler member
function, which consumes them. So, the types of their data members
should match those of the corresponding arguments of the corresponding
Handler member function.

CallFrameInfo::OffsetRule and CallFrameInfo::ValOffsetRule use an
'int' to store the rule's offset value, but
CallFrameInfo::Handler::OffsetRule and ...::ValOffsetRule expect a
'long'.  On ABIs where 'long' is larger than 'int', this can cause
values to be truncated or sign-extended unexpectedly.

This patch changes those members to 'long'.

Fortunately, offsets appearing in real DWARF call frame information
never even come close to the limits of a 32-bit int, so this bug is
unlikely to cause any practical problems.
A=jimb R=thestig

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@615 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-06-25 16:56:48 +00:00
..
client Convert files in .nib format to .xib format. 2010-06-23 20:06:13 +00:00
common Breakpad DWARF CFI parser: Use the proper type for offsets in CallFrameInfo::Rule subclasses. 2010-06-25 16:56:48 +00:00
google_breakpad Add access violation detail for windows (read/write/dep). Add stack buffer overrun and heap corruption exceptions for windows. Additional detail requested to improve Chrome crash analysis 2010-06-04 16:59:23 +00:00
processor Fix test breakage caused by my last checkin :-( 2010-06-04 20:53:20 +00:00
third_party/linux New uploader for Linux with unit tests, and gflags/glog libraries 2009-09-29 21:55:19 +00:00
tools Breakpad Mac symbol dumper: Unify with Linux dumper; support DWARF CFI. 2010-06-25 16:56:42 +00:00
breakpad_googletest_includes.h Add more error information to minidump processing return code. Also added dependency on google test, and modified minidump processing unit tests to use google test 2009-05-29 00:53:02 +00:00
config.h.in provide a network source line resolver + server. r=mark,jimb at http://breakpad.appspot.com/36001 2010-04-08 23:06:23 +00:00