Mirror of Google Breakpad project
Go to file
Bruce Dawson 73d2773f9f Avoid skipping an initializer with a goto
C++ doesn't allow skipping initialization with a goto. This means that
this code is illegal:

  void func(bool b) {
    if(b) goto END;
    int value = 0; //error C2362 with /permissive-
    //... value used here
  END:
    return;
  }

Adding an extra scope makes the code legal. This problem is only
detected with /permissive- but now that compiling with this
switch is practical we might as well stay /permissive- clean:
https://blogs.msdn.microsoft.com/vcblog/2016/11/16/permissive-switch/

Note that compiling /permissive- clean only works with the 10.0.16299.0
SDK which currently has other issues...

Bug: 773476
Change-Id: I54e64aaef46d70a817cf7da272f76d9ae5f6a6f7
Reviewed-on: https://chromium-review.googlesource.com/740287
Reviewed-by: Mark Mentovai <mark@chromium.org>
2017-10-26 22:25:57 +00:00
android sample_app: enable C++11 for Android builds 2016-04-04 21:35:26 -04:00
autotools autotools: refresh config.{sub,guess} 2017-02-06 13:57:59 -05:00
docs Update links 2016-11-18 17:24:37 +00:00
m4 Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
scripts travis: add a clang build 2017-02-17 16:53:16 +00:00
src Avoid skipping an initializer with a goto 2017-10-26 22:25:57 +00:00
.gitignore drop glog from the checkout 2017-09-13 21:35:17 +00:00
.travis.yml travis: add a clang build 2017-02-17 16:53:16 +00:00
aclocal.m4 Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
appveyor.yml Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00
AUTHORS Make build system less annoying (#8) r=bryner 2006-08-30 20:05:05 +00:00
breakpad-client.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
breakpad.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
ChangeLog Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
codereview.settings Switch to Gerrit for code reviews 2016-07-27 20:07:49 +00:00
configure Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
configure.ac Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
default.xml Roll src/src/third_party/lss/ a91633d17..e6527b0cd (1 commit) 2017-10-19 18:43:22 +00:00
DEPS Roll src/src/third_party/lss/ a91633d17..e6527b0cd (1 commit) 2017-10-19 18:43:22 +00:00
INSTALL autoreconf -f -i 2013-12-10 17:53:50 +00:00
LICENSE Renaming file COPYING to LICENSE and appending the disclaimer from src/common/convert_UTF.h to LICENSE. 2014-02-27 19:23:16 +00:00
Makefile.am Provide helper wrappers for basename(3) and dirname(3) 2017-10-18 15:44:59 +00:00
Makefile.in Provide helper wrappers for basename(3) and dirname(3) 2017-10-18 15:44:59 +00:00
NEWS Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
README.ANDROID Update symbol file documentation links. 2016-06-10 06:29:06 -04:00
README.md Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from master)

  1. First, download depot_tools and ensure that theyre in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad
    
  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
    cd src
    
  4. Build the source.

    ./configure && make
    

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check
    
  6. Optionally, install the built libraries

    make install
    

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CCd.