yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-28 00:14:14 +01:00
Code Issues Packages Projects Releases Wiki Activity
Mirror of Google Breakpad project
1,793 Commits 1 Branch 0 Tags 15 MiB
C++ 70.3%
Makefile 13.4%
C 5%
Shell 4.4%
Objective-C 3.1%
Other 3.7%
ef04c9c028
Go to file
Mike Frysinger ef04c9c028 string_conversion: fix pointer math 
Since target_ptr is of type uint16_t* already, we don't need to scale
the byte count as the language does that for us.  If it were void*, we
would need this code, but it's not.

In practice it's probably not a big deal due to how we preallocated
memory: when converting UTF8->UTF16, we'd reserve the same number of
code units, and UTF8 takes more code units per codepoint than UTF16,
so the UTF16 vector is always oversized.

When converting UTF32->UTF16, we also reserve the same number of
code units, but since one UTF32 code unit could require two UTF16
code units (for U+10000 codepoints and higher), we would probably
corrupt memory in the process.  The APIs in this module don't seem
to take into account that range in general, so for now I'm only
fixing the memory corruption.

Bug: google-breakpad:768
Change-Id: Ibfaea4e866733ff8d99b505e72c500bd40d11a74
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/1732888
Reviewed-by: Mark Mentovai <mark@chromium.org>
2019-08-05 17:38:16 +00:00
.github support mistaken-pull-closer for automatically clearing incoming PRs 2018-12-07 01:49:55 +00:00
android sample_app: enable C++11 for Android builds 2016-04-04 21:35:26 -04:00
autotools Fix Travis build by running tests as root 2018-02-20 11:08:52 +00:00
docs Add optional field indicating multiple symbols at an address 2017-11-29 21:33:23 +00:00
m4 Only use O_CLOEXEC on platforms that support it 2017-05-10 21:32:37 +00:00
scripts Fix Travis build by running tests as root 2018-02-20 11:08:52 +00:00
src string_conversion: fix pointer math 2019-08-05 17:38:16 +00:00
.gitignore drop glog from the checkout 2017-09-13 21:35:17 +00:00
.travis.yml Fix Travis build by running tests as root 2018-02-20 11:08:52 +00:00
aclocal.m4 Define and use a a new MDRawContextARM64 2018-08-01 19:27:25 +00:00
appveyor.yml Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00
AUTHORS Make build system less annoying (#8) r=bryner 2006-08-30 20:05:05 +00:00
breakpad-client.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
breakpad.pc.in make "make install" also install headers and pkgconfig files 2014-08-27 02:10:55 +00:00
ChangeLog Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
codereview.settings Switch to Gerrit for code reviews 2016-07-27 20:07:49 +00:00
configure configure.ac: Workaround gtest-config not being installed. 2019-06-14 21:21:23 +00:00
configure.ac configure.ac: Workaround gtest-config not being installed. 2019-06-14 21:21:23 +00:00
default.xml Updated lss to fix compiling with GCC 9 2019-08-03 14:31:16 +00:00
DEPS Updated lss to fix compiling with GCC 9 2019-08-03 14:31:16 +00:00
INSTALL autoreconf -f -i 2013-12-10 17:53:50 +00:00
LICENSE Renaming file COPYING to LICENSE and appending the disclaimer from src/common/convert_UTF.h to LICENSE. 2014-02-27 19:23:16 +00:00
Makefile.am string_conversion: fix pointer math 2019-08-05 17:38:16 +00:00
Makefile.in string_conversion: fix pointer math 2019-08-05 17:38:16 +00:00
NEWS Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
README.ANDROID Update symbol file documentation links. 2016-06-10 06:29:06 -04:00
README.md Appveyor CI for Windows MSVS build 2017-02-13 17:57:15 +00:00

README.md

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from master)

  1. First, download depot_tools and ensure that they’re in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad

  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
cd src

  4. Build the source.

    ./configure && make

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check

  6. Optionally, install the built libraries

    make install

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.