Increase waiting times compat.sh and ssl-opt.sh

- Some of the CI machines don't have lsof installed yet, so rely on an sleeping
an arbitrary number of seconds while the server starts. We're seeing
occasional failures with the current delay because the CI machines are highly
loaded, which seems to indicate the current delay is not quite enough, but
hopefully not to far either, so double it.

- While at it, also double the watchdog delay: while I don't remember seeing
  much failures due to client timeout, this change doesn't impact normal
running time of the script, so better err on the safe side.

These changes don't affect the test and should only affect the false positive
rate coming from the test framework in those scripts.
This commit is contained in:
Manuel Pégourié-Gonnard 2018-01-22 10:22:09 +01:00
parent 297d7535fb
commit 0d225daf7d
2 changed files with 20 additions and 6 deletions

View File

@ -888,7 +888,7 @@ if type lsof >/dev/null 2>/dev/null; then
} }
else else
wait_server_start() { wait_server_start() {
sleep 1 sleep 2
} }
fi fi

View File

@ -656,14 +656,28 @@ fi
# used by watchdog # used by watchdog
MAIN_PID="$$" MAIN_PID="$$"
# be more patient with valgrind # We use somewhat arbitrary delays for tests:
# - how long do we wait for the server to start (when lsof not available)?
# - how long do we allow for the client to finish?
# (not to check performance, just to avoid waiting indefinitely)
# Things are slower with valgrind, so give extra time here.
#
# Note: without lsof, there is a trade-off between the running time of this
# script and the risk of spurious errors because we didn't wait long enough.
# The watchdog delay on the other hand doesn't affect normal running time of
# the script, only the case where a client or server gets stuck.
if [ "$MEMCHECK" -gt 0 ]; then if [ "$MEMCHECK" -gt 0 ]; then
START_DELAY=3 START_DELAY=6
DOG_DELAY=30 DOG_DELAY=60
else else
START_DELAY=1 START_DELAY=2
DOG_DELAY=10 DOG_DELAY=20
fi fi
# some particular tests need more time:
# - for the client, we multiply the usual watchdog limit by a factor
# - for the server, we sleep for a number of seconds after the client exits
# see client_need_more_time() and server_needs_more_time()
CLI_DELAY_FACTOR=1 CLI_DELAY_FACTOR=1
SRV_DELAY_SECONDS=0 SRV_DELAY_SECONDS=0