yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-30 06:54:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #4978 from davidhorstmann-arm/2.x-fix-aarch64-asm-constraints

Browse Source 
Backport 2.x: Fix aarch64 assembly for bignum multiplication
This commit is contained in:
Gilles Peskine 2021-09-27 09:01:12 +02:00 committed by GitHub
commit 186c0216b0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog.d/muladdc-amd64-memory.txt
View File

@ -1,4 +0,0 @@
Bugfix
* Fix missing constraints on x86_64 assembly code for bignum multiplication
that broke some bignum operations with (at least) Clang 12.
Fixes #4116, #4786, #4917.

5
ChangeLog.d/muladdc-memory.txt Normal file
View File

@ -0,0 +1,5 @@
Bugfix
* Fix missing constraints on x86_64 and aarch64 assembly code
for bignum multiplication that broke some bignum operations with
(at least) Clang 12.
Fixes #4116, #4786, #4917, #4962.

8
include/mbedtls/bn_mul.h
View File

@ -244,8 +244,8 @@
#define MULADDC_CORE \ #define MULADDC_CORE \
"ldr x4, [%2], #8 \n\t" \ "ldr x4, [%2], #8 \n\t" \
"ldr x5, [%1] \n\t" \ "ldr x5, [%1] \n\t" \
"mul x6, x4, %3 \n\t" \ "mul x6, x4, %4 \n\t" \
"umulh x7, x4, %3 \n\t" \ "umulh x7, x4, %4 \n\t" \
"adds x5, x5, x6 \n\t" \ "adds x5, x5, x6 \n\t" \
"adc x7, x7, xzr \n\t" \ "adc x7, x7, xzr \n\t" \
"adds x5, x5, %0 \n\t" \ "adds x5, x5, %0 \n\t" \
@ -253,8 +253,8 @@
"str x5, [%1], #8 \n\t" "str x5, [%1], #8 \n\t"
#define MULADDC_STOP \ #define MULADDC_STOP \
: "+r" (c), "+r" (d), "+r" (s) \ : "+r" (c), "+r" (d), "+r" (s), "+m" (*(uint64_t (*)[16]) d) \
: "r" (b) \ : "r" (b), "m" (*(const uint64_t (*)[16]) s) \
: "x4", "x5", "x6", "x7", "cc" \ : "x4", "x5", "x6", "x7", "cc" \
); );