yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-30 04:44:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Abort modular inversion when modulus is one.

Browse Source 
The modular inversion function hangs when provided with the modulus
1. This commit refuses this modulus with a BAD_INPUT error code. It
also adds a test for this case.
This commit is contained in:
Hanno Becker 2017-05-11 15:59:11 +01:00
parent 88bbab22e9
commit 1c6339f966
3 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/polarssl/bignum.h
View File

@ -691,6 +691,8 @@ int mpi_fill_random( mpi *X, size_t size,
* *
* \return 0 if successful, * \return 0 if successful,
* POLARSSL_ERR_MPI_MALLOC_FAILED if memory allocation failed * POLARSSL_ERR_MPI_MALLOC_FAILED if memory allocation failed
* POLARSSL_ERR_MPI_BAD_INPUT_DATA if N is <= 1,
* POLARSSL_ERR_MPI_NOT_ACCEPTABLE if A has no inverse mod N.
*/ */
int mpi_gcd( mpi *G, const mpi *A, const mpi *B ); int mpi_gcd( mpi *G, const mpi *A, const mpi *B );

2
library/bignum.c
View File

@ -1891,7 +1891,7 @@ int mpi_inv_mod( mpi *X, const mpi *A, const mpi *N )
int ret; int ret;
mpi G, TA, TU, U1, U2, TB, TV, V1, V2; mpi G, TA, TU, U1, U2, TB, TV, V1, V2;
if( mpi_cmp_int( N, 0 ) <= 0 ) if( mpi_cmp_int( N, 1 ) <= 0 )
return( POLARSSL_ERR_MPI_BAD_INPUT_DATA ); return( POLARSSL_ERR_MPI_BAD_INPUT_DATA );
mpi_init( &TA ); mpi_init( &TU ); mpi_init( &U1 ); mpi_init( &U2 ); mpi_init( &TA ); mpi_init( &TU ); mpi_init( &U1 ); mpi_init( &U2 );

3
tests/suites/test_suite_mpi.data
View File

@ -550,6 +550,9 @@ mpi_inv_mod:10:"3":10:"-11":10:"4":POLARSSL_ERR_MPI_BAD_INPUT_DATA
Base test mpi_inv_mod #4 Base test mpi_inv_mod #4
mpi_inv_mod:10:"2":10:"4":10:"0":POLARSSL_ERR_MPI_NOT_ACCEPTABLE mpi_inv_mod:10:"2":10:"4":10:"0":POLARSSL_ERR_MPI_NOT_ACCEPTABLE
Base test mbedtls_mpi_inv_mod #5
mpi_inv_mod:10:"3":10:"1":10:"0":POLARSSL_ERR_MPI_BAD_INPUT_DATA
Test mpi_inv_mod #1 Test mpi_inv_mod #1
mpi_inv_mod:16:"aa4df5cb14b4c31237f98bd1faf527c283c2d0f3eec89718664ba33f9762907c":16:"fffbbd660b94412ae61ead9c2906a344116e316a256fd387874c6c675b1d587d":16:"8d6a5c1d7adeae3e94b9bcd2c47e0d46e778bc8804a2cc25c02d775dc3d05b0c":0 mpi_inv_mod:16:"aa4df5cb14b4c31237f98bd1faf527c283c2d0f3eec89718664ba33f9762907c":16:"fffbbd660b94412ae61ead9c2906a344116e316a256fd387874c6c675b1d587d":16:"8d6a5c1d7adeae3e94b9bcd2c47e0d46e778bc8804a2cc25c02d775dc3d05b0c":0