From 1cc6a8ea15893e3afd2dd1d95fb44423169494b7 Mon Sep 17 00:00:00 2001 From: Gilles Peskine Date: Wed, 6 Jan 2021 17:02:33 +0100 Subject: [PATCH] Add --can-pylint and --can-mypy options With just the option --can-pylint or --can-mypy, check whether the requisite tool is available with an acceptable version and exit. Signed-off-by: Gilles Peskine --- tests/scripts/check-python-files.sh | 33 +++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/tests/scripts/check-python-files.sh b/tests/scripts/check-python-files.sh index 8f8026eb3..03a147281 100755 --- a/tests/scripts/check-python-files.sh +++ b/tests/scripts/check-python-files.sh @@ -28,6 +28,39 @@ else PYTHON=python fi +can_pylint () { + # Pylint 1.5.2 from Ubuntu 16.04 is too old. + # Pylint 1.8.3 from Ubuntu 18.04 passed on the first commit containing this line. + $PYTHON -m pylint 2>/dev/null --version | awk ' + BEGIN {status = 1} + /^(pylint[0-9]*|__main__\.py) +[0-9]+\.[0-9]+/ { + split($2, version, /[^0-9]+/); + status = !(version[1] >= 2 || (version[1] == 1 && version[2] >= 8)); + exit; # executes the END block + } + END {exit status} + ' +} + +can_mypy () { + # Just check that mypy is present and looks sane. I don't know what + # minimum version is required. The check is not just "type mypy" + # becaues that passes if a mypy exists but is not installed for the current + # python version. + mypy --version 2>/dev/null >/dev/null +} + +# With just a --can-xxx option, check whether the tool for xxx is available +# with an acceptable version, and exit without running any checks. The exit +# status is true if the tool is available and acceptable and false otherwise. +if [ "$1" = "--can-pylint" ]; then + can_pylint + exit +elif [ "$1" = "--can-mypy" ]; then + can_mypy + exit +fi + $PYTHON -m pylint -j 2 scripts/mbedtls_dev/*.py scripts/*.py tests/scripts/*.py || { echo >&2 "pylint reported errors" ret=1