yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-27 01:44:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

mbedtls_mpi_cmp_mpi_ct: remove multiplications

Browse Source 
Multiplication is known to have measurable timing variations based on
the operands. For example it typically is much faster if one of the
operands is zero. Remove them from constant time code.
This commit is contained in:
Janos Follath 2019-10-11 10:43:40 +01:00
parent d80080c884
commit 1fc97594da
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
library/bignum.c
View File

@ -1175,6 +1175,11 @@ static int ct_lt_mpi_uint( const mbedtls_mpi_uint x, const mbedtls_mpi_uint y )
return ret; return ret;
} }
static int ct_bool_get_mask( unsigned int b )
{
return ~( b - 1 );
}
/* /*
* Compare signed values in constant time * Compare signed values in constant time
*/ */
@ -1206,7 +1211,7 @@ int mbedtls_mpi_cmp_mpi_ct( const mbedtls_mpi *X, const mbedtls_mpi *Y,
sign_X = X->s; sign_X = X->s;
sign_Y = Y->s; sign_Y = Y->s;
cond = ( ( sign_X ^ sign_Y ) >> ( sizeof( unsigned int ) * 8 - 1 ) ); cond = ( ( sign_X ^ sign_Y ) >> ( sizeof( unsigned int ) * 8 - 1 ) );
*ret = cond * X->s; *ret = ct_bool_get_mask( cond ) & X->s;
done = cond; done = cond;
for( i = X->n; i > 0; i-- ) for( i = X->n; i > 0; i-- )
@ -1219,8 +1224,8 @@ int mbedtls_mpi_cmp_mpi_ct( const mbedtls_mpi *X, const mbedtls_mpi *Y,
* } * }
*/ */
cond = ct_lt_mpi_uint( Y->p[i - 1], X->p[i - 1] ); cond = ct_lt_mpi_uint( Y->p[i - 1], X->p[i - 1] );
*ret |= ( cond * ( 1 - done ) ) * X->s; *ret |= ct_bool_get_mask( cond & ( 1 - done ) ) & X->s;
done |= cond * ( 1 - done ); done |= cond & ( 1 - done );
/* /*
* if( ( X->p[i - 1] < Y->p[i - 1] ) && !done ) * if( ( X->p[i - 1] < Y->p[i - 1] ) && !done )
@ -1230,9 +1235,8 @@ int mbedtls_mpi_cmp_mpi_ct( const mbedtls_mpi *X, const mbedtls_mpi *Y,
* } * }
*/ */
cond = ct_lt_mpi_uint( X->p[i - 1], Y->p[i - 1] ); cond = ct_lt_mpi_uint( X->p[i - 1], Y->p[i - 1] );
*ret |= ( cond * ( 1 - done ) ) * -X->s; *ret |= ct_bool_get_mask( cond & ( 1 - done ) ) & -X->s;
done |= cond * ( 1 - done ); done |= cond & ( 1 - done );
} }
return( 0 ); return( 0 );