yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-27 11:24:22 +01:00
Code Issues Packages Projects Releases Wiki Activity

Cleaner implementation of MBEDTLS_IGNORE_RETURN

Browse Source 
The previous implementation was misparsed in constructs like
`if (condition) MBEDTLS_IGNORE_RETURN(...); else ...;`.

Implement it as an expression, tested with GCC, Clang and MSVC.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
Gilles Peskine 2021-09-30 18:54:51 +02:00
parent 9110809c46
commit 327cb72e76
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/mbedtls/platform_util.h
View File

@ -205,8 +205,15 @@ MBEDTLS_DEPRECATED typedef int mbedtls_deprecated_numeric_constant_t;
* *
* Silences warning about unused return value given by functions * Silences warning about unused return value given by functions
* with \c MBEDTLS_CHECK_RETURN attribute. * with \c MBEDTLS_CHECK_RETURN attribute.
/* GCC doesn't silence the warning with just (void)(result).
* !(void)(result) is known to work up at least up to GCC 10, as well
* as with Clang and MSVC.
*
* https://gcc.gnu.org/onlinedocs/gcc-3.4.6/gcc/Non_002dbugs.html
* https://stackoverflow.com/questions/40576003/ignoring-warning-wunused-result
* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66425#c34
*/ */
#define MBEDTLS_IGNORE_RETURN(result) if( result ) {} #define MBEDTLS_IGNORE_RETURN(result) ( (void) !( result ) )
/** /**
* \brief Securely zeroize a buffer * \brief Securely zeroize a buffer