From 46c54c0a528469b5a98334db485b9711340003af Mon Sep 17 00:00:00 2001
From: Gilles Peskine <Gilles.Peskine@arm.com>
Date: Tue, 24 Mar 2020 16:39:30 +0100
Subject: [PATCH] Pylint: disable logging-format-interpolation warning

Pylint warns about things like ``log.info('...'.format(...))``.
It insists on ``log.info('...', ...)``.
This is of minor utility (mainly a performance gain when there are
many messages that use formatting and are below the log level).
Some versions of Pylint (including 1.8, which is the version on
Ubuntu 18.04) only recognize old-style format strings using '%',
and complain about something like ``log.info('{}', foo)`` with
logging-too-many-args (Pylint supports new-style formatting if
declared globally with logging_format_style under [LOGGING] but
this requires Pylint >=2.2).

Disable this warning to remain compatible with Pylint 1.8 and not have
to change abi_check.py to use %-formats instead of {}-formats when
logging.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
---
 .pylintrc | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/.pylintrc b/.pylintrc
index 9f5b1c4cc..a5df688d9 100644
--- a/.pylintrc
+++ b/.pylintrc
@@ -40,12 +40,22 @@ max-attributes=15
 max-module-lines=2000
 
 [MESSAGES CONTROL]
+# * logging-format-interpolation: Pylint warns about things like
+#   ``log.info('...'.format(...))``. It insists on ``log.info('...', ...)``.
+#   This is of minor utility (mainly a performance gain when there are
+#   many messages that use formatting and are below the log level).
+#   Some versions of Pylint (including 1.8, which is the version on
+#   Ubuntu 18.04) only recognize old-style format strings using '%',
+#   and complain about something like ``log.info('{}', foo)`` with
+#   logging-too-many-args (Pylint supports new-style formatting if
+#   declared globally with logging_format_style under [LOGGING] but
+#   this requires Pylint >=2.2).
 # * no-else-return: Allow the perfectly reasonable idiom
 #    if condition1:
 #        return value1
 #    else:
 #        return value2
-disable=no-else-return
+disable=logging-format-interpolation,no-else-return
 
 [REPORTS]
 # Don't diplay statistics. Just the facts.