yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-22 10:55:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Potential memory leak in ssl_ticket_keys_init()

Browse Source
This commit is contained in:
Paul Bakker 2013-12-16 15:24:05 +01:00
parent 452f6ba1a6
commit 6f0636a09f
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@ -21,6 +21,7 @@ Bugfix
* SSL now gracefully handles missing RNG * SSL now gracefully handles missing RNG
* Missing defines / cases for RSA_PSK key exchange * Missing defines / cases for RSA_PSK key exchange
* crypt_and_hash app checks MAC before final decryption * crypt_and_hash app checks MAC before final decryption
* Potential memory leak in ssl_ticket_keys_init()
= PolarSSL 1.3.2 released on 2013-11-04 = PolarSSL 1.3.2 released on 2013-11-04
Features Features

9
library/ssl_tls.c
View File

@ -3449,17 +3449,24 @@ static int ssl_ticket_keys_init( ssl_context *ssl )
return( POLARSSL_ERR_SSL_MALLOC_FAILED ); return( POLARSSL_ERR_SSL_MALLOC_FAILED );
if( ( ret = ssl->f_rng( ssl->p_rng, tkeys->key_name, 16 ) ) != 0 ) if( ( ret = ssl->f_rng( ssl->p_rng, tkeys->key_name, 16 ) ) != 0 )
{
polarssl_free( tkeys );
return( ret ); return( ret );
}
if( ( ret = ssl->f_rng( ssl->p_rng, buf, 16 ) ) != 0 || if( ( ret = ssl->f_rng( ssl->p_rng, buf, 16 ) ) != 0 ||
( ret = aes_setkey_enc( &tkeys->enc, buf, 128 ) ) != 0 || ( ret = aes_setkey_enc( &tkeys->enc, buf, 128 ) ) != 0 ||
( ret = aes_setkey_dec( &tkeys->dec, buf, 128 ) ) != 0 ) ( ret = aes_setkey_dec( &tkeys->dec, buf, 128 ) ) != 0 )
{ {
return( ret ); polarssl_free( tkeys );
return( ret );
} }
if( ( ret = ssl->f_rng( ssl->p_rng, tkeys->mac_key, 16 ) ) != 0 ) if( ( ret = ssl->f_rng( ssl->p_rng, tkeys->mac_key, 16 ) ) != 0 )
{
polarssl_free( tkeys );
return( ret ); return( ret );
}
ssl->ticket_keys = tkeys; ssl->ticket_keys = tkeys;