yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-22 16:45:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reject certificates with times not in UTC

Browse Source
This commit is contained in:
Manuel Pégourié-Gonnard 2014-04-11 12:29:49 +02:00 committed by Paul Bakker
parent 0776a43788
commit 9655e4597a
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@ -17,6 +17,7 @@ Changes
* pk_verify() now returns a specific error code when the signature is valid * pk_verify() now returns a specific error code when the signature is valid
but shorter than the supplied length. but shorter than the supplied length.
* Use UTC time to check certificate validity. * Use UTC time to check certificate validity.
* Reject certificates with times not in UTC, per RFC 5280.
Security Security
* Avoid potential timing leak in ecdsa_sign() by blinding modular division. * Avoid potential timing leak in ecdsa_sign() by blinding modular division.

4
library/x509.c
View File

@ -274,7 +274,7 @@ int x509_get_time( unsigned char **p, const unsigned char *end,
memcpy( date, *p, ( len < sizeof( date ) - 1 ) ? memcpy( date, *p, ( len < sizeof( date ) - 1 ) ?
len : sizeof( date ) - 1 ); len : sizeof( date ) - 1 );
if( sscanf( date, "%2d%2d%2d%2d%2d%2d", if( sscanf( date, "%2d%2d%2d%2d%2d%2dZ",
&time->year, &time->mon, &time->day, &time->year, &time->mon, &time->day,
&time->hour, &time->min, &time->sec ) < 5 ) &time->hour, &time->min, &time->sec ) < 5 )
return( POLARSSL_ERR_X509_INVALID_DATE ); return( POLARSSL_ERR_X509_INVALID_DATE );
@ -298,7 +298,7 @@ int x509_get_time( unsigned char **p, const unsigned char *end,
memcpy( date, *p, ( len < sizeof( date ) - 1 ) ? memcpy( date, *p, ( len < sizeof( date ) - 1 ) ?
len : sizeof( date ) - 1 ); len : sizeof( date ) - 1 );
if( sscanf( date, "%4d%2d%2d%2d%2d%2d", if( sscanf( date, "%4d%2d%2d%2d%2d%2dZ",
&time->year, &time->mon, &time->day, &time->year, &time->mon, &time->day,
&time->hour, &time->min, &time->sec ) < 5 ) &time->hour, &time->min, &time->sec ) < 5 )
return( POLARSSL_ERR_X509_INVALID_DATE ); return( POLARSSL_ERR_X509_INVALID_DATE );