yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-29 18:34:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

mbedtls_hmac_drbg_set_entropy_len() only matters when reseeding

Browse Source 
The documentation of HMAC_DRBG erroneously claimed that
mbedtls_hmac_drbg_set_entropy_len() had an impact on the initial
seeding. This is in fact not the case: mbedtls_hmac_drbg_seed() forces
the entropy length to its chosen value. Fix the documentation.
This commit is contained in:
Gilles Peskine 2019-10-04 11:52:22 +02:00 committed by Simon Butcher
parent 5fc111fe69
commit d41a95e223
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
include/mbedtls/hmac_drbg.h
View File

@ -139,13 +139,13 @@ void mbedtls_hmac_drbg_init( mbedtls_hmac_drbg_context *ctx );
* Note that SHA-256 is just as efficient as SHA-224. * Note that SHA-256 is just as efficient as SHA-224.
* The security strength can be reduced if a smaller * The security strength can be reduced if a smaller
* entropy length is set with * entropy length is set with
* mbedtls_hmac_drbg_set_entropy_len(). * mbedtls_hmac_drbg_set_entropy_len() afterwards.
* *
* \note The default entropy length is the security strength * \note The entropy length for the initial seeding is
* (converted from bits to bytes). You can override * the security strength (converted from bits to bytes).
* it mbedtls_hmac_drbg_set_entropy_len(). * You can set a different entropy length for subsequent
* \p f_entropy is always called with a length that is * seeding by calling mbedtls_hmac_drbg_set_entropy_len()
* less than or equal to the entropy length. * after this function.
* *
* \note During the initial seeding, this function calls * \note During the initial seeding, this function calls
* the entropy source to obtain a nonce * the entropy source to obtain a nonce
@ -156,6 +156,8 @@ void mbedtls_hmac_drbg_init( mbedtls_hmac_drbg_context *ctx );
* \param f_entropy The entropy callback, taking as arguments the * \param f_entropy The entropy callback, taking as arguments the
* \p p_entropy context, the buffer to fill, and the * \p p_entropy context, the buffer to fill, and the
* length of the buffer. * length of the buffer.
* \p f_entropy is always called with a length that is
* less than or equal to the entropy length.
* \param p_entropy The entropy context to pass to \p f_entropy. * \param p_entropy The entropy context to pass to \p f_entropy.
* \param custom The personalization string. * \param custom The personalization string.
* This can be \c NULL, in which case the personalization * This can be \c NULL, in which case the personalization
@ -222,13 +224,14 @@ void mbedtls_hmac_drbg_set_prediction_resistance( mbedtls_hmac_drbg_context *ctx
/** /**
* \brief This function sets the amount of entropy grabbed on each * \brief This function sets the amount of entropy grabbed on each
* seed or reseed. * reseed.
* *
* During the initial seeding, mbedtls_hmac_drbg_seed() additionally grabs * The default value is set by mbedtls_hmac_drbg_seed().
* half this amount to create the nonce.
* *
* The default value is given by the security strength, which depends on the * \note mbedtls_hmac_drbg_seed() always sets the entropy length
* hash used. See the documentation of mbedtls_hmac_drbg_seed() for details. * to the default value based on the chosen MD algorithm,
* so this function only has an effect if it is called
* after mbedtls_hmac_drbg_seed().
* *
* \param ctx The HMAC_DRBG context. * \param ctx The HMAC_DRBG context.
* \param len The amount of entropy to grab, in bytes. * \param len The amount of entropy to grab, in bytes.