Clearer function name for parity check

Return a name that more clearly returns nonzero=true=good, 0=bad. We'd
normally expect check_xxx to return 0=pass, nonzero=fail so
check_parity was a bad name.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
This commit is contained in:
Gilles Peskine 2020-08-26 11:16:50 +02:00
parent 6c75152b9f
commit ed9fbc6443

View File

@ -68,7 +68,7 @@
* The expected parity is even so that 0 is considered a valid encoding. * The expected parity is even so that 0 is considered a valid encoding.
* *
* Return 0 if value has even parity and a nonzero value otherwise. */ * Return 0 if value has even parity and a nonzero value otherwise. */
int check_parity( uint32_t value ) int has_even_parity( uint32_t value )
{ {
value ^= value >> 16; value ^= value >> 16;
value ^= value >> 8; value ^= value >> 8;
@ -76,7 +76,7 @@ int check_parity( uint32_t value )
return( 0x9669 & 1 << ( value & 0xf ) ); return( 0x9669 & 1 << ( value & 0xf ) );
} }
#define TEST_PARITY( value ) \ #define TEST_PARITY( value ) \
TEST_ASSERT( check_parity( value ) ) TEST_ASSERT( has_even_parity( value ) )
void algorithm_classification( psa_algorithm_t alg, unsigned flags ) void algorithm_classification( psa_algorithm_t alg, unsigned flags )
{ {