Simplify sign selection

Signed-off-by: Manuel Pégourié-Gonnard <manuel.pegourie-gonnard@arm.com>
This commit is contained in:
Manuel Pégourié-Gonnard 2021-06-10 09:36:41 +02:00
parent 5325b976b9
commit f10d289441

View File

@ -278,17 +278,8 @@ static int mpi_safe_cond_select_sign( int a, int b, unsigned char second )
unsigned ua = a + 1; unsigned ua = a + 1;
unsigned ub = b + 1; unsigned ub = b + 1;
/* MSVC has a warning about unary minus on unsigned integer types, /* second was 0 or 1, mask is 0 or 2 as are ua and ub */
* but this is well-defined and precisely what we want to do here. */ const unsigned mask = second << 1;
#if defined(_MSC_VER)
#pragma warning( push )
#pragma warning( disable : 4146 )
#endif
/* all-bits 1 if assign is 1, all-bits 0 if assign is 0 */
const unsigned mask = -second;
#if defined(_MSC_VER)
#pragma warning( pop )
#endif
/* select ua or ub */ /* select ua or ub */
unsigned ur = ( ua & ~mask ) | ( ub & mask ); unsigned ur = ( ua & ~mask ) | ( ub & mask );