mbedtls/bugfix_3794.txt at 1bfeb8a837260ec1ff1466e72c3c314cdce76011 - mbedtls - Gitea: Git with a cup of boomerjuice

yuzu-emu/mbedtls

mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-22 22:15:43 +01:00

Nayna Jain d696e7d91e programs/ssl: Fix incorrect EOF check in ssl_context_info.c

In `read_next_b64_code()`, the result of fgetc() is stored into a char,
but later compared against EOF, which is generally -1.  On platforms
where char is unsigned, this generates a compiler warning/error that the
comparison will never be true (causing a build failure).  The value will
never match, with the function ultimately bailing with a "Too many bad
symbols are detected" error.

On platforms with signed char, EOF is detected, but a file containing a
0xFF character will causes a premature end of file exit of the loop.

Fix this by changing the result to an int.

Fixes #3794.

Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
Signed-off-by: David Brown <david.brown@linaro.org>

2020-10-20 13:31:32 -06:00

5 lines

170 B

Plaintext

Raw Blame History

 Bugfix
   * Fix handling of EOF against 0xff bytes and on platforms with
     unsigned chars.  Fixes a build failure on platforms where char is
     unsigned.  Fixes #3794.