yuzu-emu/mbedtls
1
0
Fork 0
mirror of https://github.com/yuzu-emu/mbedtls.git synced 2024-11-26 06:35:42 +01:00
Code Issues Packages Projects Releases Wiki Activity
251bab5ceb
mbedtls/library
History
Hanno Becker 251bab5ceb Fix heap corruption in ssl_decrypt_buf 
Previously, MAC validation for an incoming record proceeded as follows:

1) Make a copy of the MAC contained in the record;
2) Compute the expected MAC in place, overwriting the presented one;
3) Compare both.

This resulted in a record buffer overflow if truncated MAC was used, as in this
case the record buffer only reserved 10 bytes for the MAC, but the MAC
computation routine in 2) always wrote a full digest.

For specially crafted records, this could be used to perform a controlled write of
up to 6 bytes past the boundary of the heap buffer holding the record, thereby
corrupting the heap structures and potentially leading to a crash or remote code
execution.

This commit fixes this by making the following change:
1) Compute the expected MAC in a temporary buffer that has the size of the
   underlying message digest.
2) Compare to this to the MAC contained in the record, potentially
   restricting to the first 10 bytes if truncated HMAC is used.

A similar fix is applied to the encryption routine `ssl_encrypt_buf`.
2017-11-20 10:31:23 +00:00
..
.gitignore
aes.c Rename website and repository 2015-03-06 13:17:10 +00:00
aesni.c Rename website and repository 2015-03-06 13:17:10 +00:00
arc4.c Rename website and repository 2015-03-06 13:17:10 +00:00
asn1parse.c Fix 1 byte overread in mbedtls_asn1_get_int() 2016-10-13 12:54:32 +01:00
asn1write.c Merge memory leak fix into branch 'mbedtls-1.3' 2016-01-02 00:28:19 +00:00
base64.c Add comment to integer overflow fix in base64.c 2017-02-25 21:27:17 +00:00
bignum.c Merge remote-tracking branch 'hanno/mpi_read_file_underflow_backport-1.3' into mbedtls-1.3 2017-06-08 19:54:29 +02:00
blowfish.c Rename website and repository 2015-03-06 13:17:10 +00:00
camellia.c Rename website and repository 2015-03-06 13:17:10 +00:00
ccm.c Fix for MSVC Compiler warnings 2016-11-10 15:40:53 +00:00
certs.c Rename website and repository 2015-03-06 13:17:10 +00:00
cipher_wrap.c Rename website and repository 2015-03-06 13:17:10 +00:00
cipher.c Fix integer overflows in buffer bound checks 2017-02-25 21:25:44 +00:00
CMakeLists.txt Update version to 1.3.21 2017-08-10 11:52:14 +01:00
ctr_drbg.c Fix integer overflows in buffer bound checks 2017-02-25 21:25:44 +00:00
debug.c Revert "Avoid formatting debug message uselessly" 2015-08-10 17:36:47 +02:00
des.c Rename website and repository 2015-03-06 13:17:10 +00:00
dhm.c Backport 1.3: Check rc of mbedtls_mpi_fill_random 2017-07-20 01:26:53 +02:00
ecdh.c Rename website and repository 2015-03-06 13:17:10 +00:00
ecdsa.c Rename website and repository 2015-03-06 13:17:10 +00:00
ecp_curves.c ECP: Prevent freeing a buffer on stack 2017-02-28 20:24:52 +00:00
ecp.c Backport 1.3: Check rc of mbedtls_mpi_fill_random 2017-07-20 01:26:53 +02:00
entropy_poll.c Fix -Wshadow warnings 2015-08-31 11:07:51 +02:00
entropy.c Rename time and index parameter to avoid name conflict. 2017-07-28 22:08:16 +01:00
error.c Only return VERIFY_FAILED from a single point 2017-07-28 13:15:57 +01:00
gcm.c Backport 1.3: check if iv is zero in gcm. 2017-07-20 00:33:27 +02:00
havege.c Rename website and repository 2015-03-06 13:17:10 +00:00
hmac_drbg.c Fix use of deprecated function in the library 2015-03-20 18:23:52 +00:00
Makefile Make ar invocation more portable 2016-01-08 15:28:40 +01:00
md2.c Fix integer overflows in buffer bound checks 2017-02-25 21:25:44 +00:00
md4.c Fix warning with MD/SHA ALT implementation 2015-08-31 11:22:47 +02:00
md5.c Fix warning with MD/SHA ALT implementation 2015-08-31 11:22:47 +02:00
md_wrap.c Rename website and repository 2015-03-06 13:17:10 +00:00
md.c Add POLARSSL_DEPRECATED_{WARNING,REMOVED} 2015-03-23 14:11:11 +01:00
memory_buffer_alloc.c Rename website and repository 2015-03-06 13:17:10 +00:00
net.c Add brackets around net.c macro arguments 2017-10-07 22:22:04 +01:00
oid.c Fix typo in an OID name 2015-10-27 15:12:39 +01:00
padlock.c Fix bug in Via Padlock support 2015-04-02 10:53:59 +01:00
pbkdf2.c Add POLARSSL_DEPRECATED_{WARNING,REMOVED} 2015-03-23 14:11:11 +01:00
pem.c Fix buffer overreads in mbedtls_pem_read_buffer() 2017-02-25 21:25:06 +00:00
pk_wrap.c Fix data loss in unsigned int cast in PK 2017-02-15 10:44:02 +00:00
pk.c Fix data loss in unsigned int cast in PK 2017-02-15 10:44:02 +00:00
pkcs5.c Add missing 'const' on selftest data 2015-03-11 09:13:42 +00:00
pkcs11.c Rename website and repository 2015-03-06 13:17:10 +00:00
pkcs12.c Fix stack buffer overflow in pkcs12 2015-09-30 16:46:07 +02:00
pkparse.c Fix bug in pk_parse_key() 2015-04-15 11:21:24 +02:00
pkwrite.c Fix other occurrences of same bounds check issue 2015-10-27 11:47:37 +01:00
platform.c Fix compile errors with NO_STD_FUNCTIONS 2015-06-03 10:20:33 +01:00
ripemd160.c Rename website and repository 2015-03-06 13:17:10 +00:00
rsa.c Merge remote-tracking branch 'restricted/iotssl-1138-rsa-padding-check-1.3-restricted' into mbedtls-1.3-restricted 2017-06-08 20:34:40 +02:00
sha1.c Fix warning with MD/SHA ALT implementation 2015-08-31 11:22:47 +02:00
sha256.c Fix warning with MD/SHA ALT implementation 2015-08-31 11:22:47 +02:00
sha512.c Fix warning with MD/SHA ALT implementation 2015-08-31 11:22:47 +02:00
ssl_cache.c Rename website and repository 2015-03-06 13:17:10 +00:00
ssl_ciphersuites.c Remember suitable hash function for any signature algorithm. 2017-05-24 10:47:54 +01:00
ssl_cli.c Fix mbedtls_ssl_read 2017-06-08 15:59:38 +01:00
ssl_srv.c Parse Signature Algorithm ext when renegotiating 2017-10-11 14:06:26 +01:00
ssl_tls.c Fix heap corruption in ssl_decrypt_buf 2017-11-20 10:31:23 +00:00
threading.c Rename website and repository 2015-03-06 13:17:10 +00:00
timing.c Increase tolerance of timing selftest 2015-08-19 14:48:34 +02:00
version_features.c Update features list 2016-10-13 22:11:15 +01:00
version.c Rename website and repository 2015-03-06 13:17:10 +00:00
x509_create.c Fix other occurrences of same bounds check issue 2015-10-27 11:47:37 +01:00
x509_crl.c Fix potential integer overflow parsing DER CRL 2017-07-27 11:49:08 +01:00
x509_crt.c Fix implementation-defined integer conversion 2017-07-28 13:15:57 +01:00
x509_csr.c Prevent signed integer overflow in CSR parsing 2017-07-27 11:50:58 +01:00
x509.c Correctly handle leap year in x509_date_is_valid() 2017-10-12 21:08:46 +01:00
x509write_crt.c Rename time and index parameter to avoid name conflict. 2017-07-28 22:08:16 +01:00
x509write_csr.c Add missing bounds check in X509 DER write funcs 2016-10-13 12:45:07 +01:00
xtea.c Rename website and repository 2015-03-06 13:17:10 +00:00