From 5c739f14f546f0f4ec074a943479361f9c165081 Mon Sep 17 00:00:00 2001 From: Fam Zheng Date: Fri, 23 Feb 2018 14:09:35 -0500 Subject: [PATCH] util: Fix MIN_NON_ZERO MIN_NON_ZERO(1, 0) is evaluated to 0. Rewrite the macro to fix it. Backports commit b6ece2c6f37926a994bc564a9e55ef3be6016d8f from qemu --- qemu/include/qemu/osdep.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu/include/qemu/osdep.h b/qemu/include/qemu/osdep.h index 7599e34b..36d32a58 100644 --- a/qemu/include/qemu/osdep.h +++ b/qemu/include/qemu/osdep.h @@ -134,7 +134,8 @@ /* Minimum function that returns zero only iff both values are zero. * Intended for use with unsigned values only. */ #ifndef MIN_NON_ZERO -#define MIN_NON_ZERO(a, b) (((a) != 0 && (a) < (b)) ? (a) : (b)) +#define MIN_NON_ZERO(a, b) ((a) == 0 ? (b) : \ + ((b) == 0 ? (a) : (MIN(a, b)))) #endif /* Round number down to multiple */