diff --git a/qemu/target-i386/cpu.c b/qemu/target-i386/cpu.c index 6920decf..558d5a72 100644 --- a/qemu/target-i386/cpu.c +++ b/qemu/target-i386/cpu.c @@ -2998,7 +2998,7 @@ static int x86_cpu_realizefn(struct uc_struct *uc, DeviceState *dev, Error **err Error *local_err = NULL; FeatureWord w; - if (cpu->apic_id < 0) { + if (cpu->apic_id == UNASSIGNED_APIC_ID) { error_setg(errp, "apic-id property was not initialized properly"); return -1; } @@ -3159,7 +3159,7 @@ static void x86_cpu_initfn(struct uc_struct *uc, Object *obj, void *opaque) NULL, NULL, (void *)cpu->filtered_features, NULL); cpu->hyperv_spinlock_attempts = HYPERV_SPINLOCK_NEVER_RETRY; - cpu->apic_id = -1; + cpu->apic_id = UNASSIGNED_APIC_ID; x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort); } diff --git a/qemu/target-i386/cpu.h b/qemu/target-i386/cpu.h index 44ea80a2..b3003a23 100644 --- a/qemu/target-i386/cpu.h +++ b/qemu/target-i386/cpu.h @@ -844,6 +844,11 @@ typedef struct { #define NB_OPMASK_REGS 8 +/* CPU can't have 0xFFFFFFFF APIC ID, use that value to distinguish + * that APIC ID hasn't been set yet + */ +#define UNASSIGNED_APIC_ID 0xFFFFFFFF + typedef union X86LegacyXSaveArea { struct { uint16_t fcw; @@ -1161,7 +1166,7 @@ typedef struct X86CPU { bool expose_kvm; bool migratable; bool host_features; - int64_t apic_id; + uint32_t apic_id; /* if true the CPUID code directly forward host cache leaves to the guest */ bool cache_info_passthrough;