diff --git a/qemu/tcg/tcg-op.h b/qemu/tcg/tcg-op.h index 075f2ff2..ce66b9d3 100644 --- a/qemu/tcg/tcg-op.h +++ b/qemu/tcg/tcg-op.h @@ -268,6 +268,7 @@ static inline void tcg_gen_op6ii_i64(TCGContext *s, TCGOpcode opc, TCGv_i64 a1, static inline void gen_set_label(TCGContext *s, TCGLabel *l) { + l->present = 1; tcg_gen_op1(s, INDEX_op_set_label, label_arg(s, l)); } diff --git a/qemu/tcg/tcg.c b/qemu/tcg/tcg.c index d60b4ecf..b627baf5 100644 --- a/qemu/tcg/tcg.c +++ b/qemu/tcg/tcg.c @@ -254,6 +254,9 @@ TCGLabel *gen_new_label(TCGContext *s) TCGLabel ltmp = {0}; ltmp.id = s->nb_labels++; *l = ltmp; +#ifdef CONFIG_DEBUG_TCG + QSIMPLEQ_INSERT_TAIL(&s->labels, l, next); +#endif return l; } @@ -516,6 +519,9 @@ void tcg_func_start(TCGContext *s) QTAILQ_INIT(&s->ops); QTAILQ_INIT(&s->free_ops); +#ifdef CONFIG_DEBUG_TCG + QSIMPLEQ_INIT(&s->labels); +#endif } static inline TCGTemp *tcg_temp_alloc(TCGContext *s) @@ -3270,6 +3276,23 @@ int tcg_gen_code(TCGContext *s, TranslationBlock *tb) } #endif +#ifdef CONFIG_DEBUG_TCG + /* Ensure all labels referenced have been emitted. */ + { + TCGLabel *l; + bool error = false; + + QSIMPLEQ_FOREACH(l, &s->labels, next) { + if (unlikely(!l->present) && l->refs) { + qemu_log_mask(CPU_LOG_TB_OP, + "$L%d referenced but not present.\n", l->id); + error = true; + } + } + assert(!error); + } +#endif + #ifdef CONFIG_PROFILER s->opt_time -= profile_getclock(); #endif diff --git a/qemu/tcg/tcg.h b/qemu/tcg/tcg.h index 2a0259fd..bf4977cb 100644 --- a/qemu/tcg/tcg.h +++ b/qemu/tcg/tcg.h @@ -250,16 +250,21 @@ typedef struct TCGRelocation { intptr_t addend; } TCGRelocation; -typedef struct TCGLabel { +typedef struct TCGLabel TCGLabel; +struct TCGLabel { + unsigned present : 1; unsigned has_value : 1; - unsigned id : 15; + unsigned id : 14; unsigned refs : 16; union { uintptr_t value; tcg_insn_unit *value_ptr; TCGRelocation *first_reloc; } u; -} TCGLabel; +#ifdef CONFIG_DEBUG_TCG + QSIMPLEQ_ENTRY(TCGLabel) next; +#endif +}; typedef struct TCGPool { struct TCGPool *next; @@ -775,6 +780,7 @@ struct TCGContext { #endif #ifdef CONFIG_DEBUG_TCG + QSIMPLEQ_HEAD(, TCGLabel) labels; int temps_in_use; int goto_tb_issue_mask; #endif