mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2024-10-20 12:48:22 +02:00
13b3a6c92f
We had some pointless differences in the generated code for visit, command marshalling, and events; unifying them makes it easier for future patches to consolidate to common helper functions. This is one patch of a series to clean up these differences. This patch reduces the number of push_indent()/pop_indent() pairs so that generated code is typically already at its natural output indentation in the python files. It is easier to reason about generated code if the reader does not have to track how much spacing will be inserted alongside the code, and moreso when all of the generators use the same patterns (qapi-type and qapi-event were already using in-place indentation). Arguably, the resulting python may be a bit harder to read with C code at the same indentation as python; on the other hand, not having to think about push_indent() is a win, and most decent editors provide syntax highlighting that makes it easier to visually distinguish python code from string literals that will become C code. There is no change to the generated output. Backports commit 05372f708a8cb3556e4d67458de79417dadf241f from qemu |
||
|---|---|---|
| .. | ||
| create_config | ||
| make_device_config.sh | ||
| ordereddict.py | ||
| qapi-event.py | ||
| qapi-types.py | ||
| qapi-visit.py | ||
| qapi.py | ||