mirror of
https://github.com/yuzu-emu/unicorn.git
synced 2024-10-20 14:28:20 +02:00
7f741a6c9b
Making each visitor provide its own (awkwardly-named) FOO_cleanup()
is unusual, when we can instead have a polymorphic visit_free()
interface. Over the next few patches, we can use the polymorphic
functions to eliminate the need for a FOO_get_visitor() function
for accessing specific visitor functionality, once everything can
be accessed directly through the Visitor* interfaces.
The dealloc visitor is the first one converted to completely use
the new entry point, since qapi_dealloc_visitor_cleanup() was the
only reason that qapi_dealloc_get_visitor() existed, and only
generated and testsuite code was even using it. With the new
visit_free() entry point in place, we no longer need to expose
the QapiDeallocVisitor subtype through qapi_dealloc_visitor_new(),
and can get by with less generated code, with diffs that look like:
| void qapi_free_ACPIOSTInfo(ACPIOSTInfo *obj)
| {
|- QapiDeallocVisitor *qdv;
| Visitor *v;
|
| if (!obj) {
| return;
| }
|
|- qdv = qapi_dealloc_visitor_new();
|- v = qapi_dealloc_get_visitor(qdv);
|+ v = qapi_dealloc_visitor_new();
| visit_type_ACPIOSTInfo(v, NULL, &obj, NULL);
|- qapi_dealloc_visitor_cleanup(qdv);
|+ visit_free(v);
|}
Backports commit 2c0ef9f411ae6081efa9eca5b3eab2dbeee45a6c from qemu
29 lines
656 B
C
29 lines
656 B
C
/*
|
|
* Dealloc Visitor
|
|
*
|
|
* Copyright IBM, Corp. 2011
|
|
*
|
|
* Authors:
|
|
* Michael Roth <mdroth@linux.vnet.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
|
|
* See the COPYING.LIB file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#ifndef QAPI_DEALLOC_VISITOR_H
|
|
#define QAPI_DEALLOC_VISITOR_H
|
|
|
|
#include "qapi/visitor.h"
|
|
|
|
typedef struct QapiDeallocVisitor QapiDeallocVisitor;
|
|
|
|
/*
|
|
* The dealloc visitor is primarly used only by generated
|
|
* qapi_free_FOO() functions, and is the only visitor designed to work
|
|
* correctly in the face of a partially-constructed QAPI tree.
|
|
*/
|
|
Visitor *qapi_dealloc_visitor_new(void);
|
|
|
|
#endif
|