Eric Blake 9ca55f4ba5 qapi: Don't let implicit enum MAX member collide ... Now that we guarantee the user doesn't have any enum values beginning with a single underscore, we can use that for our own purposes. Renaming ENUM_MAX to ENUM__MAX makes it obvious that the sentinel is generated. This patch was mostly generated by applying a temporary patch: |diff --git a/scripts/qapi.py b/scripts/qapi.py |index e6d014b..b862ec9 100644 |--- a/scripts/qapi.py |+++ b/scripts/qapi.py |@@ -1570,6 +1570,7 @@ const char *const %(c_name)s_lookup[] = { | max_index = c_enum_const(name, 'MAX', prefix) | ret += mcgen(''' | [%(max_index)s] = NULL, |+// %(max_index)s | }; | ''', | max_index=max_index) then running: $ cat qapi-{types,event}.c tests/test-qapi-types.c | sed -n 's,^// \(.*\)MAX,s|\1MAX|\1_MAX|g,p' > list $ git grep -l _MAX | xargs sed -i -f list The only things not generated are the changes in scripts/qapi.py. Rejecting enum members named 'MAX' is now useless, and will be dropped in the next patch. Backports commit 7fb1cf1606c78c9d5b538f29176fd5a101726a9d from qemu		2018-02-19 20:34:53 -05:00
..
create_config	more cleanup qemu/configure	2017-01-19 14:11:54 +08:00
make_device_config.sh	fix file perms	2015-08-28 21:05:38 -07:00
ordereddict.py	import	2015-08-21 15:04:50 +08:00
qapi-event.py	qapi: Share gen_visit_fields()	2018-02-19 18:41:41 -05:00
qapi-types.py	qapi-types: Simplify gen_struct_field[s]	2018-02-19 20:06:38 -05:00
qapi-visit.py	qapi: Track simple union tag in object.local_members	2018-02-19 20:02:03 -05:00
qapi.py	qapi: Don't let implicit enum MAX member collide	2018-02-19 20:34:53 -05:00