yuzu-emu/yuzu-android
1
0
Fork 0
mirror of https://github.com/yuzu-emu/yuzu-android.git synced 2024-12-05 01:33:47 +01:00
Code Issues Packages Projects Releases Wiki Activity
4ef3329f81
yuzu-android/src/yuzu/configuration
History
Lioncash 4ef3329f81 configuration/config: Move config loading and saving to functions based off groups 
Over time our config values have grown quite numerous in size.
Unfortunately it also makes the single functions we have for loading and
saving values more error prone.

For example, we were loading the core settings twice when they only
should have been loaded once. In another section, a variable was
shadowing another variable used to load settings from a completely
different section.

Finally, in one other case, there was an extraneous endGroup() call used
that didn't need to be done. This was essentially dead code and also a
bug waiting to happen.

This separates the section loading code into its own separate functions.
This keeps variables only visible to the code that actually needs it,
and makes it much easier to visually see the end of each individual
configuration group. It also makes it much easier to visually catch bugs
during code review.

While we're at it, this also uses QStringLiteral instead of raw string
literals, which both avoids constructing a lot of QString instances, but
also makes it much easier to disable implicit ASCII to QString and
vice-versa in the future via setting QT_NO_CAST_FROM_ASCII and
QT_NO_CAST_TO_ASCII as compilation flags.
2019-05-09 00:52:49 -04:00
..
config.cpp configuration/config: Move config loading and saving to functions based off groups 2019-05-09 00:52:49 -04:00
config.h configuration/config: Move config loading and saving to functions based off groups 2019-05-09 00:52:49 -04:00
configure_audio.cpp audio_core: Make g_sink_details internally linked 2018-12-13 16:44:32 -05:00
configure_audio.h yuzu/configuration: Make slots private where applicable 2018-12-02 14:18:36 -05:00
configure_audio.ui Add audio stretching support 2018-09-08 18:26:23 +01:00
configure_debug.cpp yuzu/configuration/configure_debug: Remove unused header inclusions 2019-01-17 11:51:47 -05:00
configure_debug.h yuzu/configuration: Make slots private where applicable 2018-12-02 14:18:36 -05:00
configure_debug.ui patch_manager: Show LayeredExeFS patch in add-ons column 2018-11-20 19:22:34 -05:00
configure_dialog.cpp configure_dialog: Amend constructor initializer list order 2019-04-09 19:39:43 -04:00
configure_dialog.h yuzu: Make hotkeys configurable via the GUI 2019-03-16 03:55:57 +01:00
configure_gamelist.cpp Merge pull request #1640 from DarkLordZach/game-list-reload 2018-11-18 19:24:53 -08:00
configure_gamelist.h yuzu/configuration: Add missing override specifiers to configuration-related classes 2018-12-02 14:18:36 -05:00
configure_gamelist.ui game_list: Make add-ons column optional 2018-11-01 20:27:12 -04:00
configure_general.cpp ui_settings: Rename game directory variables 2019-04-11 19:55:56 +02:00
configure_general.h yuzu: Make hotkeys configurable via the GUI 2019-03-16 03:55:57 +01:00
configure_general.ui Merge pull request #2132 from FearlessTobi/port-4437 2019-04-09 18:08:30 -04:00
configure_graphics.cpp Allow picking a Compatibility Profile for OpenGL. 2019-04-20 00:05:24 -04:00
configure_graphics.h Use QPixmap/QIcon for background color selection button 2019-01-26 15:08:54 +01:00
configure_graphics.ui Allow picking a Compatibility Profile for OpenGL. 2019-04-20 00:05:24 -04:00
configure_hotkeys.cpp configure_hotkeys: Pass the dialog as a parent to SequenceDialog() 2019-04-09 20:06:49 -04:00
configure_hotkeys.h configure_hotkey: Remove unnecessary include 2019-04-09 19:37:08 -04:00
configure_hotkeys.ui yuzu: Make hotkeys configurable via the GUI 2019-03-16 03:55:57 +01:00
configure_input_player.cpp yuzu/configuration/configure_input_player: Forward declare types where applicable 2019-01-17 12:08:15 -05:00
configure_input_player.h yuzu/configuration/configure_input_player: Forward declare types where applicable 2019-01-17 12:08:15 -05:00
configure_input_player.ui configure_input_player: Set minimum width on controls 2018-11-18 23:22:36 -05:00
configure_input_simple.cpp configure_input_simple: Make input profile array constexpr 2018-12-26 17:36:36 -05:00
configure_input_simple.h configure_input: Add ConfigureInputSimple as default input UI config 2018-12-05 14:02:02 -05:00
configure_input_simple.ui configure_input: Add ConfigureInputSimple as default input UI config 2018-12-05 14:02:02 -05:00
configure_input.cpp configure_input_simple: Properly signal docked mode change 2018-12-05 14:05:57 -05:00
configure_input.h configure_input_simple: Properly signal docked mode change 2018-12-05 14:05:57 -05:00
configure_input.ui configure_input: Convert into QDialog 2018-12-05 14:02:02 -05:00
configure_mouse_advanced.cpp yuzu/configure_input: Make CallConfigureDialog a non-member template function 2018-11-27 16:37:18 -05:00
configure_mouse_advanced.h yuzu/configure_input*: Move data members after function declarations 2018-11-27 05:02:15 -05:00
configure_mouse_advanced.ui qt: Add UI to configure mouse buttons 2018-11-18 23:22:36 -05:00
configure_per_general.cpp yuzu/configuration/configure_per_general: Remove unused header inclusions 2019-01-17 11:58:43 -05:00
configure_per_general.h yuzu/configuration/configure_per_general: Remove unused header inclusions 2019-01-17 11:58:43 -05:00
configure_per_general.ui qt: Add UI to display game properties and disable add-ons 2018-12-03 17:21:25 -05:00
configure_profile_manager.cpp qt: Move profile manager to own UI tab 2019-01-04 17:32:13 -05:00
configure_profile_manager.h qt: Move profile manager to own UI tab 2019-01-04 17:32:13 -05:00
configure_profile_manager.ui qt: Move profile manager to own UI tab 2019-01-04 17:32:13 -05:00
configure_system.cpp yuzu/configuration/configure_system: Remove unused header inclusions 2019-01-17 11:50:57 -05:00
configure_system.h qt: Move profile manager to own UI tab 2019-01-04 17:32:13 -05:00
configure_system.ui qt: Provide UI to edit custom RTC settings 2019-01-07 19:19:40 -05:00
configure_touchscreen_advanced.cpp hid: Use player-defined controller type as PREFERRED_CONTROLLER 2018-11-18 23:22:36 -05:00
configure_touchscreen_advanced.h yuzu/configuration/configure_touchscreen_advanced: Remove unnecessary header inclusions 2019-01-17 12:02:01 -05:00
configure_touchscreen_advanced.ui qt: Add UI to configure touchscreen parameters 2018-11-18 23:22:36 -05:00
configure_web.cpp yuzu/configuration/configure_web: Remove an unused lambda capture 2019-01-17 11:39:49 -05:00
configure_web.h yuzu/configuration: Make slots private where applicable 2018-12-02 14:18:36 -05:00
configure_web.ui Port web_service from Citra 2018-10-02 15:30:48 +02:00
configure.ui yuzu: Make hotkeys configurable via the GUI 2019-03-16 03:55:57 +01:00