yuzu-android/src
Lioncash d8deb39b83 svc: Handle memory writing explicitly within QueryProcessMemory
Moves the memory writes directly into QueryProcessMemory instead of
letting the wrapper function do it. It would be inaccurate to allow the
handler to do it because there's cases where memory shouldn't even be
written to. For example, if the given process handle is invalid.

HOWEVER, if the memory writing is within the wrapper, then we have no
control over if these memory writes occur, meaning in an error case, 68
bytes of memory randomly get trashed with zeroes, 64 of those being
written to wherever the memory info address points to, and the remaining
4 being written wherever the page info address points to.

One solution in this case would be to just conditionally check within
the handler itself, but this is kind of smelly, given the handler
shouldn't be performing conditional behavior itself, it's a behavior of
the managed function. In other words, if you remove the handler from the
equation entirely, does the function still retain its proper behavior?
In this case, no.

Now, we don't potentially trash memory from this function if an invalid
query is performed.
2018-12-12 15:43:31 -05:00
..
audio_core core: Port all current usages of Event to Readable/WritableEvent 2018-11-29 08:45:41 -05:00
common Backport review comment from citra-emu/citra#4418 2018-12-07 16:21:18 +01:00
core svc: Handle memory writing explicitly within QueryProcessMemory 2018-12-12 15:43:31 -05:00
input_common
tests global: Use std::optional instead of boost::optional (#1578) 2018-10-30 00:03:25 -04:00
video_core Merge pull request #1740 from FernandoS27/shader_props 2018-12-10 12:43:43 -05:00
web_service compatdb: Use a seperate endpoint for testcase submission 2018-10-28 13:23:02 +01:00
yuzu Merge pull request #1819 from DarkLordZach/disable-addons 2018-12-10 21:52:19 -05:00
yuzu_cmd qt: Add Properties menu to game list right-click 2018-12-04 13:34:50 -05:00
.clang-format
CMakeLists.txt