settings: Resolve a sign conversion warning within GetTimeZoneString()

A sign conversion warning was occurring due to an int < size_t
comparison.
This commit is contained in:
Lioncash 2020-07-15 13:45:20 -04:00
parent 5dbf91d739
commit af5a56ddc4

View File

@ -67,18 +67,18 @@ Values values = {};
bool configuring_global = true; bool configuring_global = true;
std::string GetTimeZoneString() { std::string GetTimeZoneString() {
static constexpr std::array<const char*, 46> timezones{{ static constexpr std::array timezones{
"auto", "default", "CET", "CST6CDT", "Cuba", "EET", "Egypt", "Eire", "auto", "default", "CET", "CST6CDT", "Cuba", "EET", "Egypt", "Eire",
"EST", "EST5EDT", "GB", "GB-Eire", "GMT", "GMT+0", "GMT-0", "GMT0", "EST", "EST5EDT", "GB", "GB-Eire", "GMT", "GMT+0", "GMT-0", "GMT0",
"Greenwich", "Hongkong", "HST", "Iceland", "Iran", "Israel", "Jamaica", "Japan", "Greenwich", "Hongkong", "HST", "Iceland", "Iran", "Israel", "Jamaica", "Japan",
"Kwajalein", "Libya", "MET", "MST", "MST7MDT", "Navajo", "NZ", "NZ-CHAT", "Kwajalein", "Libya", "MET", "MST", "MST7MDT", "Navajo", "NZ", "NZ-CHAT",
"Poland", "Portugal", "PRC", "PST8PDT", "ROC", "ROK", "Singapore", "Turkey", "Poland", "Portugal", "PRC", "PST8PDT", "ROC", "ROK", "Singapore", "Turkey",
"UCT", "Universal", "UTC", "W-SU", "WET", "Zulu", "UCT", "Universal", "UTC", "W-SU", "WET", "Zulu",
}}; };
ASSERT(Settings::values.time_zone_index.GetValue() < timezones.size()); const auto time_zone_index = static_cast<std::size_t>(values.time_zone_index.GetValue());
ASSERT(time_zone_index < timezones.size());
return timezones[Settings::values.time_zone_index.GetValue()]; return timezones[time_zone_index];
} }
void Apply() { void Apply() {