yuzu-emu/breakpad
1
0
Fork 0
mirror of https://github.com/yuzu-emu/breakpad.git synced 2024-11-24 14:05:45 +01:00
Code Issues Packages Projects Releases Wiki Activity

Removing redundant calls to string::c_str().

Browse Source 
https://breakpad.appspot.com/539002/



git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1139 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
ivan.penkov@gmail.com 2013-03-29 21:37:42 +00:00
parent bbaca6bc00
commit c5ceea7d74
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/client/linux/minidump_writer/minidump_writer_unittest.cc
View File

@ -199,7 +199,7 @@ TEST(MinidumpWriterTest, MappingInfo) {
// Read the minidump. Load the module list, and ensure that // Read the minidump. Load the module list, and ensure that
// the mmap'ed |memory| is listed with the given module name // the mmap'ed |memory| is listed with the given module name
// and debug ID. // and debug ID.
Minidump minidump(templ.c_str()); Minidump minidump(templ);
ASSERT_TRUE(minidump.Read()); ASSERT_TRUE(minidump.Read());
MinidumpModuleList* module_list = minidump.GetModuleList(); MinidumpModuleList* module_list = minidump.GetModuleList();
@ -318,7 +318,7 @@ TEST(MinidumpWriterTest, MappingInfoContained) {
// Read the minidump. Load the module list, and ensure that // Read the minidump. Load the module list, and ensure that
// the mmap'ed |memory| is listed with the given module name // the mmap'ed |memory| is listed with the given module name
// and debug ID. // and debug ID.
Minidump minidump(dumpfile.c_str()); Minidump minidump(dumpfile);
ASSERT_TRUE(minidump.Read()); ASSERT_TRUE(minidump.Read());
MinidumpModuleList* module_list = minidump.GetModuleList(); MinidumpModuleList* module_list = minidump.GetModuleList();
@ -400,7 +400,7 @@ TEST(MinidumpWriterTest, DeletedBinary) {
ASSERT_EQ(0, stat(templ.c_str(), &st)); ASSERT_EQ(0, stat(templ.c_str(), &st));
ASSERT_GT(st.st_size, 0); ASSERT_GT(st.st_size, 0);
Minidump minidump(templ.c_str()); Minidump minidump(templ);
ASSERT_TRUE(minidump.Read()); ASSERT_TRUE(minidump.Read());
// Check that the main module filename is correct. // Check that the main module filename is correct.
@ -481,7 +481,7 @@ TEST(MinidumpWriterTest, AdditionalMemory) {
mappings, memory_list)); mappings, memory_list));
// Read the minidump. Ensure that the memory region is present // Read the minidump. Ensure that the memory region is present
Minidump minidump(templ.c_str()); Minidump minidump(templ);
ASSERT_TRUE(minidump.Read()); ASSERT_TRUE(minidump.Read());
MinidumpMemoryList* dump_memory_list = minidump.GetMemoryList(); MinidumpMemoryList* dump_memory_list = minidump.GetMemoryList();
@ -551,7 +551,7 @@ TEST(MinidumpWriterTest, InvalidStackPointer) {
ASSERT_TRUE(WriteMinidump(templ.c_str(), child, &context, sizeof(context))); ASSERT_TRUE(WriteMinidump(templ.c_str(), child, &context, sizeof(context)));
// Read the minidump. Ensure that the memory region is present // Read the minidump. Ensure that the memory region is present
Minidump minidump(templ.c_str()); Minidump minidump(templ);
ASSERT_TRUE(minidump.Read()); ASSERT_TRUE(minidump.Read());
// TODO(ted.mielczarek,mkrebs): Enable this part of the test once // TODO(ted.mielczarek,mkrebs): Enable this part of the test once
@ -652,7 +652,7 @@ TEST(MinidumpWriterTest, MinidumpSizeLimit) {
ASSERT_GT(st.st_size, 0); ASSERT_GT(st.st_size, 0);
normal_file_size = st.st_size; normal_file_size = st.st_size;
Minidump minidump(normal_dump.c_str()); Minidump minidump(normal_dump);
ASSERT_TRUE(minidump.Read()); ASSERT_TRUE(minidump.Read());
MinidumpThreadList* dump_thread_list = minidump.GetThreadList(); MinidumpThreadList* dump_thread_list = minidump.GetThreadList();
ASSERT_TRUE(dump_thread_list); ASSERT_TRUE(dump_thread_list);
@ -719,7 +719,7 @@ TEST(MinidumpWriterTest, MinidumpSizeLimit) {
// in like it was supposed to. // in like it was supposed to.
EXPECT_LT(st.st_size, normal_file_size); EXPECT_LT(st.st_size, normal_file_size);
Minidump minidump(limit_dump.c_str()); Minidump minidump(limit_dump);
ASSERT_TRUE(minidump.Read()); ASSERT_TRUE(minidump.Read());
MinidumpThreadList* dump_thread_list = minidump.GetThreadList(); MinidumpThreadList* dump_thread_list = minidump.GetThreadList();
ASSERT_TRUE(dump_thread_list); ASSERT_TRUE(dump_thread_list);