ivan.penkov@gmail.com
1a7a0a4d4b
Fixing a mem leak in test code
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@975 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-06-29 22:34:04 +00:00
ivan.penkov@gmail.com
6de969a304
This change allows compiling the google-breakpad code using a global ::string class instead of std::string. For more details take a look at common/using_std_string.h
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@974 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-06-28 22:46:01 +00:00
digit@chromium.org
93cebf538e
Fix Android build of client library
...
http://breakpad.appspot.com/401002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@973 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-06-27 14:04:52 +00:00
thestig@chromium.org
5f4fd97781
Fix a race condition in AutoCriticalSection.
...
CID=104232
Review URL: https://breakpad.appspot.com/398002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@972 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-06-19 23:42:18 +00:00
ivan.penkov@gmail.com
1208a8e369
This is a fix for a stackwalker_x86 issue which has to
...
do with FPO (frame-pointer-omission) optimized context
frames where the context frame represents a Windows
System call stub.
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@971 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-06-12 21:18:45 +00:00
mark@chromium.org
c50346b341
CrashGenerationServer's state machine can be invoked from both the application
...
thread and thread pool threads. This CL serializes access to the FSM state.
Handling of crash dump and client shutdown requests is still done
asynchronously.
Patch by Alex Pakhunov <alexeypa@chromium.org>
BUG=132164
TEST=remoting_unittests.BreakpadWinDeathTest.*
Review URL: https://breakpad.appspot.com/396002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@970 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-06-12 21:06:11 +00:00
qsr@chromium.org
fd67ff286e
Fix uploader so that it send the guid to the server.
...
Review URL: https://breakpad.appspot.com/391002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@969 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-06-06 08:02:48 +00:00
mkrebs@chromium.org
d6b6959e0e
sym_upload: Show failure if symbol server gives redirect response
...
Add a "response_code" parameter to Linux's HTTPUpload::SendRequest() that,
if non-NULL, will be set to the response code of the HTTP request. Using
that, sym_upload will print a failure message on Linux if the response code
is not 200. This is in line with the change made by
http://breakpad.appspot.com/77001/ for the Mac version.
BUG=google-breakpad:480, chromium-os:30032
TEST=Ran "sym_upload powertop.sym http://test.webdav.org/redir-tmp/ "
Ran "sym_upload powertop.sym http://clients2.google.com/cr/staging_symbol "
Review URL: https://breakpad.appspot.com/388002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@968 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-24 20:22:48 +00:00
thestig@chromium.org
4191cae361
Initialize a CustomClientInfo variable. (Coverity)
...
Review URL: https://breakpad.appspot.com/390003
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@967 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-15 22:33:29 +00:00
mark@chromium.org
df8d4f964f
Increase kMinidumpFileLengthLimit from 800000 to 2MB.
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@966 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-15 22:30:15 +00:00
qsr@chromium.org
d3ad7c4c99
Fixing HTTPMultipartUpload.
...
The ending boundary for multipart must replace the last boundary, not added
after it.
Review URL: https://breakpad.appspot.com/390002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@965 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-15 15:41:08 +00:00
qsr@chromium.org
bbc3789df1
Unprotect the allocator before trying to create a minidump from a signal.
...
It is impossible to write a minidump with memory protected. This means that
before this change, no minidump were created when a signal was caught, instead
the application froze.
Review URL: https://breakpad.appspot.com/389002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@964 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-14 11:34:01 +00:00
mark@chromium.org
05d61dfd83
Bits necessary to send the reports along with the minidumps.
...
Currently the log file and the minidump are uploaded in two consequent requests,
thus they get different report ids and it's hard to associate them to each
other.
This CL makes the crash uploader send the minidump and the log file together in
a single multipart request, so that they have the same report id and are
accessible from the same landing page.
Patch by Alexander Potapenko <glider@chromium.org>
Review URL: https://breakpad.appspot.com/387003/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@963 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-11 14:12:43 +00:00
jessicag.feedback
daf16276b4
Fix warning in r961 - C4800
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@962 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-07 21:31:31 +00:00
cdn@chromium.org
fa31053b42
wires up the crash client side so that the deferred upload callback can be used.
...
TEST=N/A
Review URL: https://breakpad.appspot.com/384001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@961 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-05-03 18:15:11 +00:00
jimblandy
d1118d6e14
In the AMD64 stackwalker, use heuristics to provide %rbp more often, as
...
subsequent frames are usually unable to use CFI if they don't have an %rbp
value.
a=mrmiller, r=jimb
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@960 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-25 21:11:10 +00:00
ted.mielczarek
e6e778f635
Fix race in VerifyStackReadWithMultipleThreads
...
Patch by Chris Dearman <chris@mips.com>
R=ted at http://breakpad.appspot.com/377002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@959 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-25 11:42:52 +00:00
ted.mielczarek
e8dbecb42c
Fix compiler warning from format string
...
Patch by Chris Dearman <chris@mips.com>
R=ted at http://breakpad.appspot.com/369002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@958 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-25 11:42:33 +00:00
ted.mielczarek
24c3c97633
Fix compilation warnings related to unchecked return values
...
Patch by Chris Dearman <chris@mips.com>
R=benchan at http://breakpad.appspot.com/377001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@957 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-25 11:22:09 +00:00
ted.mielczarek
258f2459fc
Reap child in VerifyStackReadWithMultipleThreads
...
Patch by Chris Dearman <chris@mips.com>
R=benchan at http://breakpad.appspot.com/378001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@956 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-25 11:21:45 +00:00
thestig@chromium.org
dff2d3e632
Make Breakpad build with DSO linking on newer versions of Fedora/Ubuntu.
...
BUG=444
TEST=compiles
Kudos to pkwarren at geeee mail.com for coming up with this 5 months ago.
Review URL: https://breakpad.appspot.com/382001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@955 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-19 18:31:37 +00:00
benchan@chromium.org
fb7dbb4c28
Fix file descriptor leak in GetThreadInfoByIndex
...
Patch by Chris Dearman <chris@mips.com>
Review URL: http://breakpad.appspot.com/376001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@954 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-18 15:33:54 +00:00
cdn@chromium.org
05f02b46ed
Set limit on the number of custom client info entries that can be sent with a crash dump.
...
BUG=123709
TEST=N/A
Review URL: https://breakpad.appspot.com/377004
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@953 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-17 18:20:22 +00:00
cdn@chromium.org
9a3de4160b
Expose a callback to allow crash server implementations to defer the uploading of crash dumps to a later time. The client can provide a crash_id when the dump is performed and then at a later time connect again and request that the crash id be uploaded triggering an implementation defined callback.
...
BUG=473
TEST=CrashGenerationServerTest.*
Review URL: https://breakpad.appspot.com/379001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@952 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-13 22:20:30 +00:00
ted.mielczarek
789eac95fd
Fix file descriptor leaks in ExternalDumper test
...
Patch by Chris Dearman <chris@mips.com>
R=ted at http://breakpad.appspot.com/372002/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@951 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-11 20:44:09 +00:00
ted.mielczarek
de8292b1d4
Fix crash_generator error message
...
Patch by Chris Dearman <chris@mips.com>
R=ted at http://breakpad.appspot.com/374001/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@950 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-11 20:39:35 +00:00
thestig@chromium.org
88ccbb4804
vectors are cleared with "clear()", not with "empty()
...
A=thakis@chromium.org
R=thestig@chromium.org
Original code review: https://breakpad.appspot.com/377003/
Review URL: https://breakpad.appspot.com/380001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@949 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-11 03:47:07 +00:00
qsr@chromium.org
a66d4b272a
Fixed "unused method" warning, reported by Xcode 4.2 on simulator.
...
Patch by tball@google.com
Review URL: https://breakpad.appspot.com/371002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@948 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-04 11:06:35 +00:00
jimblandy
c6485cb937
Accept version 3 .eh_frame unwinding data, as well as version 1.
...
a=michaelrmmiller
r=jimblandy
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@947 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-03 23:12:34 +00:00
benchan@chromium.org
a9d27c5ea0
Add missing log.o dependency to linux_client_unittest target.
...
r945 introduced src/client/linux/log/log.c, which is used in
exception_handler.cc, and thus should be added as a dependency
in the linux_client_unittest target.
TEST=Compile and run unit tests on Linux.
Review URL: https://breakpad.appspot.com/373001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@946 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-03 17:11:12 +00:00
mark@chromium.org
4f291f0307
Changes to get the breakpad client compiling and running on Android using
...
ndk-7b.
Patch by Carlos Valdivia <carlosvaldivia@google.com>
Review URL: https://breakpad.appspot.com/363001/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@945 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-03 16:38:53 +00:00
ted.mielczarek@gmail.com
ae38954f50
Remove redundant include of CPP specific header files
...
Patch by Chris Dearman <chris@mips.com>
R=ted at http://breakpad.appspot.com/372001/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@944 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-03 12:54:37 +00:00
ted.mielczarek@gmail.com
7585a27356
Fix several issues in linux_dumper_unittest_helper
...
Patch by Chris Dearman <chris@mips.com>
R=ted at http://breakpad.appspot.com/369001/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@943 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-04-03 12:48:43 +00:00
mkrebs@chromium.org
78373e45c5
Fix for putting main module as first one in minidump
...
The first module in a minidump is expected to be for the main executable.
We used to assume that /proc/<pid>/maps always showed that one first, but in
some cases that is no longer true (see comment #7 of the bug). So this
change makes use of the entry point stored in auxv to make sure we put the
correct module first.
BUG=chromium-os:25355
TEST=Ran Breakpad tests
Review URL: https://breakpad.appspot.com/366002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@942 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-30 23:53:32 +00:00
mkrebs@chromium.org
70f5af9444
Fix GetMainModule() to properly get first module
...
Change MinidumpModuleList::GetMainModule() to use GetModuleAtIndex() instead
of GetModuleAtSequence() because the former gets the first module that was
in the minidump file, while the latter actually gets the first module when
sorted by address. While this is pretty much the same thing at the moment,
I have another change in the works that can sometimes affect the module
order in the file.
BUG=chromium-os:25355
TEST=Ran Breakpad tests
Review URL: https://breakpad.appspot.com/366001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@941 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-30 21:59:16 +00:00
benchan@chromium.org
1d8752bf0f
Fix memory leak in DisassemblerX86.
...
A memory leak in DisassemblerX86 is detected by valgrind. This patch
fixes the DisassemblerX86 destructor to properly free the |current_instr_|
variable.
BUG=471
TEST=Run valgrind on disassembler_x86_unittest to verify the leak is gone.
Review URL: https://breakpad.appspot.com/371001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@940 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-30 21:01:09 +00:00
mark@chromium.org
f6147a6460
Fix one more -Wnull-conversion warning.
...
Patch by Nico Weber <thakis@chromium.org>
Review URL: https://breakpad.appspot.com/370001/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@939 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-30 20:36:32 +00:00
mark@chromium.org
07b3445bf1
Fix -Wnull-conversion warnings in breakpad.
...
Patch by Nico Weber <thakis@chromium.org>
Review URL: https://breakpad.appspot.com/367001/
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@938 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-30 14:30:06 +00:00
benchan@chromium.org
a5477bbfab
Fix class/struct mismatches in forward declarations.
...
This patch fixes some compiler warnings when compiling with clang.
BUG=none
TEST=Compile with clang and run unit tests.
Review URL: https://breakpad.appspot.com/368001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@937 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-30 05:01:50 +00:00
cdn@chromium.org
e89a7747b8
Unregister waits when a client shuts down so that no further callback events can
...
fire for that client.
BUG=117890
TEST=N/A
Review URL: https://breakpad.appspot.com/365001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@936 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-22 18:01:50 +00:00
qsr@chromium.org
1e8d2d5a4c
Add high level API for breakpad on iOS.
...
The new API allows to automatically upload repports to the crash server when the application restarts.
This change also:
- Correct a bug on the test for correct alignment of the abrt signal handler
- Add user friendly information on crashes for SIGABRT and NSException
Review URL: https://breakpad.appspot.com/361001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@935 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-13 20:02:40 +00:00
qsr@chromium.org
7facb6a6fb
Change iOS implementation to not use exc_server
...
Instead of using exc_server, the message is parsed directly, and the minidump
is created, then the app is killed.
Moreover, the only catch exception is exception_raise. This patch remove all
rereference to exception_raise_state and exception_raise_state_identity.
Review URL: https://breakpad.appspot.com/358001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@934 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-09 19:22:10 +00:00
qsr@chromium.org
b1f858f26b
Add SIGABRT handler for mac and iOS.
...
SIGABRT were not handled while in process. This change add a signal handler to
handle this.
Review URL: https://breakpad.appspot.com/360001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@933 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-09 19:11:58 +00:00
nealsid
61b5dcb168
Add COPYING file per libcurl distribution requirements
...
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@932 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-09 16:15:20 +00:00
qsr@chromium.org
fe7f63632f
Remove static initializer in linux/guid_creator.cc.
...
There was a static initializer generated for this file in Chrome for Android.
Patch by pliard@chromium.org
Original review: http://breakpad.appspot.com/359001/
Review URL: https://breakpad.appspot.com/359002
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@931 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-08 18:47:26 +00:00
qsr@chromium.org
76acc0edcd
Removing breakpad_exc_server and all references.
...
This was aimed at replacing exc_server, but was not used.
Review URL: https://breakpad.appspot.com/357001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@930 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-08 00:02:58 +00:00
qsr@chromium.org
af7d5ccf7b
Correct various compilation warnings.
...
- Cast result of _dyld_image_count to prevent compilation warning: The 2 int
in both side of the ? operator should have the same type.
- Remove unused variable for return values.
- Remove unused NSUserDefaults.
Review URL: https://breakpad.appspot.com/354001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@929 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-07 00:18:29 +00:00
qsr@chromium.org
04548babac
Send uptime as milliseconds for Mac and iOS.
...
All other platform are sending uptime as milliseconds. Changing the
implementation to do the same on Mac and iOS.
Review URL: https://breakpad.appspot.com/355001
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@928 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-03-02 08:27:20 +00:00
mark@chromium.org
84a55c5a72
Support for .raSearch in the x86 stackwalker
...
Patch by Benjamin Smedberg <bsmedberg@gmail.com>
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@927 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-02-23 22:56:53 +00:00
mark@chromium.org
26c31918f7
Handle program strings with the assignment operator smashed against the next
...
token.
Patch by Benjamin Smedberg <bsmedberg@gmail.com>
git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@926 4c0a9323-5329-0410-9bdc-e9ce6186880e
2012-02-23 22:41:36 +00:00