Rose Zadik
a7a6155272
Update ecp.h
...
One fix. Removed trailing whitespaces
2018-04-24 13:14:01 +01:00
Rose Zadik
d35340550d
Update ecp.h
...
fixed omittion
2018-04-23 16:12:42 +01:00
Rose Zadik
c32efb3f64
Update ecp.h
...
Resolved last review comment
2018-04-23 09:38:29 +01:00
Rose Zadik
d76ac587d3
Update ecp.h
...
Changes based on review comments. Waiting for responses on 2 remaining comments
2018-04-23 06:29:34 +01:00
Rose Zadik
f089fa3341
Update ecp.h
...
minor spacing/comment format fixes
2018-04-20 10:41:16 +01:00
Rose Zadik
b2e111a288
Update ecp.h
...
Changes based on review comments.
2 comments still open pending decisions
2018-04-20 10:13:48 +01:00
Rose Zadik
f56cb34d60
Update ecp.h
...
Updated based on review comment.
One comment remains open (waiting for input)
2018-04-19 12:49:10 +01:00
Rose Zadik
d3c9bfcbeb
Update ecp.h
...
Reviewed and standardized
2018-04-17 10:56:55 +01:00
Manuel Pégourié-Gonnard
4ca9a45756
Merge remote-tracking branch 'public/pr/1560' into development-proposed
...
* public/pr/1560:
Warn if using a memory sanitizer on AESNI
2018-04-11 13:06:30 +02:00
Manuel Pégourié-Gonnard
e72d3225a7
Merge remote-tracking branch 'public/pr/1559' into development-proposed
...
* public/pr/1559:
Make the memset call prior to FD_ZERO conditional to needing it
2018-04-11 13:05:31 +02:00
Gilles Peskine
5053efde33
Warn if using a memory sanitizer on AESNI
...
Clang-Msan is known to report spurious errors when MBEDTLS_AESNI_C is
enabled, due to the use of assembly code. The error reports don't
mention AES, so they can be difficult to trace back to the use of
AES-NI. Warn about this potential problem at compile time.
2018-04-05 15:37:38 +02:00
Gilles Peskine
ec4733b645
Make the memset call prior to FD_ZERO conditional to needing it
...
Zeroing out an fd_set before calling FD_ZERO on it is in principle
useless, but without it some memory sanitizers think the fd_set is
still uninitialized after FD_ZERO (e.g. clang-msan/Glibc/x86_64 where
FD_ZERO is implemented in assembly). Make the zeroing conditional on
using a memory sanitizer.
2018-04-05 14:55:47 +02:00
Gilles Peskine
80aa3b8d65
Merge branch 'pr_946' into development-proposed
2018-04-04 10:33:45 +02:00
Gilles Peskine
5c77f2ef37
Merge remote-tracking branch 'upstream-public/pr/1535' into development-proposed
2018-04-04 10:31:09 +02:00
Gilles Peskine
e4d3b7f860
Fix merge glitch in ChangeLog
2018-04-04 09:28:48 +02:00
Gilles Peskine
b9e8696d56
Merge remote-tracking branch 'upstream-public/pr/1142' into development-proposed
2018-04-04 09:20:59 +02:00
Gilles Peskine
315b460593
Merge remote-tracking branch 'upstream-public/pr/1457' into development-proposed
2018-04-04 09:19:27 +02:00
Gilles Peskine
73db8380ca
Merge remote-tracking branch 'upstream-public/pr/1547' into development-proposed
2018-04-04 09:19:12 +02:00
Gilles Peskine
be2371c3d9
Merge branch 'pr_348' into development-proposed
2018-04-04 09:18:27 +02:00
Gilles Peskine
557e77d9a3
Add ChangeLog entry
2018-04-04 09:18:11 +02:00
Gilles Peskine
a09453f495
Merge branch 'pr_1395' into development-proposed
2018-04-04 09:14:12 +02:00
Gilles Peskine
d6953b58d7
Improve changelog entry
2018-04-04 09:09:29 +02:00
Gilles Peskine
1fae860f0f
Merge remote-tracking branch 'upstream-public/pr/1543' into development-proposed
2018-04-04 09:03:25 +02:00
Hanno Becker
f4e5b7e87d
Additionally initialize fd_set's via memset in mbedtls_net_poll
...
The initialization via FD_SET is not seen by memory sanitizers if
FD_SET is implemented through assembly. Additionally zeroizing the
respective fd_set's before calling FD_SET contents the sanitizers
and comes at a negligible computational overhead.
2018-04-03 16:28:09 +01:00
Andrzej Kurek
b364053a87
pk_sign: add stdlib include
2018-04-03 06:16:04 -04:00
Kevin Luty
0cbe816bfc
ChangeLog updated and returning proper value
2018-04-02 10:01:16 -05:00
mohammad1603
19d392b258
Fix compatibility problem in the printed message
...
Replace %zu with %lu and add cast for the printed value.
2018-04-02 07:35:50 -07:00
Gilles Peskine
90a8b5219f
Merge branch 'pr_1480' into development-proposed
2018-04-01 12:44:06 +02:00
Gilles Peskine
092bf3dd38
Add original PR reference
2018-04-01 12:43:48 +02:00
Gilles Peskine
0ed632f445
Merge remote-tracking branch 'upstream-public/pr/1499' into development-proposed
2018-04-01 12:41:22 +02:00
Gilles Peskine
5e4464e392
Merge remote-tracking branch 'upstream-public/pr/1539' into development-proposed
2018-04-01 12:40:37 +02:00
Gilles Peskine
695d557dcf
Merge branch 'pr_1180' into development-proposed
2018-04-01 12:26:36 +02:00
Gilles Peskine
4045c74421
Minor changelog improvement
2018-04-01 12:25:48 +02:00
Gilles Peskine
c96ccf4b3f
Add ChangeLog entry to credit independent contribution
...
Also: fixes #1437
2018-03-31 22:57:03 +02:00
Gilles Peskine
039fd12834
Robustness fix in mbedtls_ssl_derive_keys
...
In mbedtls_ssl_derive_keys, don't call mbedtls_md_hmac_starts in
ciphersuites that don't use HMAC. This doesn't change the behavior of
the code, but avoids relying on an uncaught error when attempting to
start an HMAC operation that hadn't been initialized.
2018-03-31 22:53:49 +02:00
Gilles Peskine
cc78ac46e7
Update error.c
2018-03-30 18:52:10 +02:00
Gilles Peskine
5114d3e4e1
Clarify the use of MBEDTLS_ERR_PK_SIG_LEN_MISMATCH
...
Clarify what MBEDTLS_ERR_ECP_SIG_LEN_MISMATCH and
MBEDTLS_ERR_PK_SIG_LEN_MISMATCH mean. Add comments to highlight that
this indicates that a valid signature is present, unlike other error
codes. See
https://github.com/ARMmbed/mbedtls/pull/1149#discussion_r178130705
2018-03-30 18:43:16 +02:00
Darryl Green
eea1c4ee5a
Improve documentation of mbedtls_ssl_write()
2018-03-29 16:41:09 +01:00
Nicholas Wilson
08f3ef1861
Basic support for Curve448, similar to the current level of support for Curve25519
2018-03-29 14:29:06 +01:00
Andrzej Kurek
a357f1a6ca
Move changelog entry to bugfix from changes
2018-03-29 08:17:15 -04:00
Azim Khan
19d1373bb9
Enable SSL test scripts to dump logs on stdout
2018-03-29 11:10:57 +01:00
Jaeden Amero
4ba87fc958
Merge remote-tracking branch 'upstream-public/pr/758' into development-proposed
2018-03-29 11:01:38 +01:00
Jaeden Amero
2ad47e3bcc
Merge remote-tracking branch 'upstream-public/pr/1528' into development-proposed
2018-03-29 11:00:50 +01:00
Jaeden Amero
78a03ec230
Merge remote-tracking branch 'upstream-public/pr/1379' into development-proposed
2018-03-29 10:57:57 +01:00
Jaeden Amero
5031a9a278
Merge remote-tracking branch 'upstream-public/pr/1134' into development-proposed
...
Fixes #504 and fixes #1057
2018-03-29 10:53:42 +01:00
mohammad1603
52aecb9a7f
Check whether INT_MAX larger than SIZE_MAX scenario
...
Check whether INT_MAX larger than SIZE_MAX scenario
2018-03-28 23:41:40 -07:00
Jaeden Amero
90226be779
Merge remote-tracking branch 'upstream-public/pr/1467' into development-proposed
2018-03-28 15:35:22 +01:00
Jaeden Amero
2843d21d99
Merge remote-tracking branch 'upstream-public/pr/1523' into development-proposed
2018-03-28 15:32:13 +01:00
Hanno Becker
2bd57578af
Merge branch 'development' into iotssl-1204
2018-03-28 14:52:35 +01:00
Jaeden Amero
5ec118352e
Merge remote-tracking branch 'upstream-public/pr/1474' into development-proposed
2018-03-28 14:22:29 +01:00